Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace account class hash with constant value #178

Merged
merged 3 commits into from
Nov 20, 2023
Merged

feat: replace account class hash with constant value #178

merged 3 commits into from
Nov 20, 2023

Conversation

stanleyyconsensys
Copy link
Collaborator

replace account class hash with constant value

@sonarqubecloud SonarQubeCloud
Copy link

[consensys_starknet-snap-starknet-snap] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarqubecloud SonarQubeCloud
Copy link

[consensys_starknet-snap-wallet-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@stanleyyconsensys stanleyyconsensys marked this pull request as ready for review November 17, 2023 09:18
@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner November 17, 2023 09:18
@stanleyyconsensys stanleyyconsensys merged commit f588c9c into main Nov 20, 2023
@stanleyyconsensys stanleyyconsensys deleted the feat/migrate-account-hash branch November 20, 2023 10:47
@github-actions github-actions bot mentioned this pull request Nov 20, 2023
Merged
This was referenced Nov 26, 2024
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wantedsystem wantedsystem wantedsystem approved these changes

@Akaryatrh Akaryatrh Awaiting requested review from Akaryatrh Akaryatrh is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stanleyyconsensys @wantedsystem