Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sign transaction ongoing #158

Merged
merged 11 commits into from
Nov 10, 2023
Merged

feat: sign transaction ongoing #158

merged 11 commits into from
Nov 10, 2023

Conversation

wantedsystem
Copy link
Contributor

No description provided.

stanleyyconsensys
stanleyyconsensys requested changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing unit test

packages/starknet-snap/src/signTransaction.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/signTransaction.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/signTransaction.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/signTransaction.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/signTransaction.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/types/snapApi.ts Show resolved Hide resolved
stanleyyconsensys
stanleyyconsensys requested changes Nov 7, 2023
View reviewed changes
packages/starknet-snap/index.html Outdated Show resolved Hide resolved
packages/starknet-snap/src/signTransaction.ts Show resolved Hide resolved
packages/starknet-snap/src/utils/starknetUtils.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/signTransaction.ts Outdated Show resolved Hide resolved
packages/starknet-snap/src/utils/starknetUtils.ts Outdated Show resolved Hide resolved
packages/starknet-snap/index.html Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

[consensys_starknet-snap-starknet-snap] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.2% 84.2% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 9, 2023

[consensys_starknet-snap-wallet-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@stanleyyconsensys stanleyyconsensys marked this pull request as ready for review November 9, 2023 07:53
@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner November 9, 2023 07:53
wantedsystem
wantedsystem commented Nov 9, 2023
View reviewed changes
Copy link
Contributor Author

@wantedsystem wantedsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanleyyconsensys stanleyyconsensys merged commit 0b7a8b1 into main Nov 10, 2023
@stanleyyconsensys stanleyyconsensys deleted the feat/sign-transaction branch November 10, 2023 00:57
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Merged
This was referenced Nov 26, 2024
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajpai244 bajpai244 bajpai244 left review comments

@stanleyyconsensys stanleyyconsensys stanleyyconsensys approved these changes

@Akaryatrh Akaryatrh Awaiting requested review from Akaryatrh Akaryatrh is a code owner automatically assigned from Consensys/snaps-factory-reviewers

@jonesho jonesho Awaiting requested review from jonesho jonesho is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wantedsystem @bajpai244 @stanleyyconsensys