-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why do all nodes run blockvoting strategy #31
Comments
Thanks for posting this issue, this is currently being reviewed. |
From a consensus point of view there are no resources wasted. There is an internal event mechanism that dictates when a new vote tx must be broadcasted or a new block must be created. When that event is raised the vote/block maker logic is notified. That logic will check if the node is configured as a voter or block maker node. And if not it does nothing. |
But doesn't that mean non blockmaker nodes are applying new transactions (executing) to the pending state, only to redo this once a new block comes in. Shouldn't only block makers be building on the pending state? |
The non blockmakers still need the pending state to validate any transactions submitted through them, no? |
Where can I learn about your complete consensus strategy ? |
Please see #266 |
All nodes irrespective of their block making and/or voting rights run the BlockVoting strategy (Generate block creation events, create a block, vote, apply transactions to pending state, reset pending state & pause/resume block making scheduler). Aren't quorum nodes without a block generation key and/or vote key 'wasting' processing cycles from a consensus perspective.
The text was updated successfully, but these errors were encountered: