Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do all nodes run blockvoting strategy #31

Closed
magooster opened this issue Dec 15, 2016 · 7 comments
Closed

Why do all nodes run blockvoting strategy #31

magooster opened this issue Dec 15, 2016 · 7 comments

Comments

@magooster
Copy link

All nodes irrespective of their block making and/or voting rights run the BlockVoting strategy (Generate block creation events, create a block, vote, apply transactions to pending state, reset pending state & pause/resume block making scheduler). Aren't quorum nodes without a block generation key and/or vote key 'wasting' processing cycles from a consensus perspective.

@davoell
Copy link
Contributor

davoell commented Jan 6, 2017

Thanks for posting this issue, this is currently being reviewed.

@bas-vk
Copy link
Contributor

bas-vk commented Jan 13, 2017

From a consensus point of view there are no resources wasted. There is an internal event mechanism that dictates when a new vote tx must be broadcasted or a new block must be created. When that event is raised the vote/block maker logic is notified. That logic will check if the node is configured as a voter or block maker node. And if not it does nothing.

@magooster
Copy link
Author

magooster commented Jan 26, 2017

But doesn't that mean non blockmaker nodes are applying new transactions (executing) to the pending state, only to redo this once a new block comes in. Shouldn't only block makers be building on the pending state?

@gsalgado
Copy link
Contributor

The non blockmakers still need the pending state to validate any transactions submitted through them, no?

@sivachaitanya
Copy link

Where can I learn about your complete consensus strategy ?

@patrickmn
Copy link
Contributor

Please see #266

@patrickmn
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants