Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to disable specific topics #19

Merged
merged 3 commits into from
Oct 15, 2020

Conversation

matkt
Copy link
Collaborator

@matkt matkt commented Oct 14, 2020

Signed-off-by: Karim TAAM [email protected]

PR Description

As a Besu node admin I would like to be able to disable specific topics in the event stream feature so that topics that I don't need are not published to the broker. For instance, disable the Blocks topic.

add new CLI option : --plugin-kafka-enabled-topic=LOG,BLOCK

Acceptance Criteria

  • Be able to disable a specific topic using the usual configuration system
  • Default should be the current behaviour with all topics enabled
  • Displaying disabled/enabled topics in a log when starting would be a plus

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

@matkt matkt marked this pull request as ready for review October 14, 2020 09:11
@matkt matkt requested review from AbdelStark and davemec October 14, 2020 12:35
Copy link

@davemec davemec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@matkt matkt merged commit 5675ccd into Consensys:master Oct 15, 2020
@matkt matkt added doc-change-required documentation Improvements or additions to documentation and removed doc-change-required labels Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] as a Besu node admin I would like to be able to disable specific topics
3 participants