Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Conversation

@davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Sep 15, 2022

closes #3658

@davidmurdoch davidmurdoch changed the title Merge things feat: add support for the merge hardfork Sep 20, 2022
@MicaiahReid MicaiahReid changed the base branch from ejsbeta to the-merge September 23, 2022 15:52
@MicaiahReid MicaiahReid changed the base branch from the-merge to ejsbeta September 23, 2022 15:52
@davidmurdoch davidmurdoch changed the base branch from ejsbeta to the-merge September 23, 2022 15:52
@davidmurdoch davidmurdoch changed the base branch from the-merge to ejsbeta September 23, 2022 15:52
@davidmurdoch davidmurdoch marked this pull request as ready for review September 23, 2022 19:19
};
};

isPostMerge: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For later when we clean up tech debt: does this make sense to define here? This flag is used all throughout the file, so it seems like it would make sense at the top.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a good idea to move it up in the file, yeah.

Base automatically changed from ejsbeta to the-merge September 23, 2022 19:44
@davidmurdoch davidmurdoch merged commit d024369 into the-merge Sep 23, 2022
@davidmurdoch davidmurdoch deleted the merge-things branch September 23, 2022 21:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants