Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you remove wasdk target when both "uwp, wasdk" are specified in GenerateAllSolution.ps1? #247

Open
2 of 20 tasks
HO-COOH opened this issue Jan 23, 2025 · 1 comment
Labels
bug 🐛 Something isn't working

Comments

@HO-COOH
Copy link

HO-COOH commented Jan 23, 2025

Describe the bug

I just wasted several hours trying to figure out why is my wasdk gallery project suddenly missing in the main toolkit project. And I finally found this out. I don't understand what this comment is saying. And from my experience, the two gallery (the uwp, and wasdk) works perfectly in peace before.

And if that's a necessary change, you should document it clearly (and oh look even the screenshots is not reflecting the change), and also change the GenerateAllSolution.bat to an option like:

  • uwp, wasm
  • wasdk, wasm

The current default value is just a confusing contradiction to what you did, and will keep others wasting more hours on this.

Oh and a more funny thing is, why removing wasdk target instead of uwp when uwp is considered dead?

Steps to reproduce

n/a

Expected behavior

n/a

Screenshots

No response

Code Platform

  • UWP
  • WinAppSDK / WinUI 3
  • Web Assembly (WASM)
  • Android
  • iOS
  • MacOS
  • Linux / GTK

Windows Build Number

  • Windows 10 1809 (Build 17763)
  • Windows 10 1903 (Build 18362)
  • Windows 10 1909 (Build 18363)
  • Windows 10 2004 (Build 19041)
  • Windows 10 20H2 (Build 19042)
  • Windows 10 21H1 (Build 19043)
  • Windows 11 21H2 (Build 22000)
  • Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

  • Windows 10, version 1809 (Build 17763)
  • Windows 10, version 1903 (Build 18362)
  • Windows 10, version 1909 (Build 18363)
  • Windows 10, version 2004 (Build 19041)
  • Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item.

@HO-COOH HO-COOH added the bug 🐛 Something isn't working label Jan 23, 2025
@Arlodotexe
Copy link
Member

Arlodotexe commented Jan 23, 2025

You can find more background on this here and here.

The short answer is that both UWP with modern .NET (not uap) and Windows App SDK are using the exact same TFM and cannot be loaded in the solution simultaneously using different UI frameworks. As of adding modern UWP, one or the other must be requested when generating the solution.

If you need to work with WinUI 3 / Wasdk instead of our default (uwp), pass the -winui 3 parameter in when generating the solution:

.\tooling\GenerateAllSolution.ps1 -MultiTargets wasdk,wasm,android,ios -Components Media,SettingsControls -winui 3 

The Components and MultiTargets params can be customized as needed for your scenario. Removing these params will generate uwp or wasdk + wasm, depending on the -winui value given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants