Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] RoamingSettings helpers should not depend on Windows #86

Closed
shweaver-MSFT opened this issue Apr 5, 2021 · 0 comments
Closed

Comments

@shweaver-MSFT
Copy link
Member

Describe the problem this feature would solve

The issue is described well here: CommunityToolkit/WindowsCommunityToolkit#3903

Basically, the IObjectStorageHelper has a small/unnecessary Windows dependency, preventing us from putting the roaming settings helpers in the NetStandard CommunityToolkit.Net.Graph package.

Describe the solution

Move the IObectStorageHelper in WCT to a NetStandard package, and consume from the new location. Then migrate the roaming settings helpers over to the CommunityToolkit.Net.Graph package.

Describe alternatives you've considered

They are functional where they are, but we can offer to a greater audience if we remove the unnecessary dependency on Windows.

Additional context & Screenshots

@shweaver-MSFT shweaver-MSFT self-assigned this Apr 5, 2021
@shweaver-MSFT shweaver-MSFT added this to the 7.1.0 milestone Jun 11, 2021
@shweaver-MSFT shweaver-MSFT mentioned this issue Jun 11, 2021
17 tasks
@ghost ghost added the In-PR 🚀 label Jul 20, 2021
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Aug 2, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant