Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Separate Graph SDK interaction into own package #75

Closed
shweaver-MSFT opened this issue Mar 2, 2021 · 2 comments · Fixed by #76
Closed

[Feature] Separate Graph SDK interaction into own package #75

shweaver-MSFT opened this issue Mar 2, 2021 · 2 comments · Fixed by #76
Milestone

Comments

@shweaver-MSFT
Copy link
Member

shweaver-MSFT commented Mar 2, 2021

Describe the problem this feature would solve

I don't want the bloat of the entire Graph SDK if I only need to do authentication.

Describe the solution

The Graph SDK isn't really needed for authentication. There is a smaller Graph.Auth package we can use to get the core constructs to enable the sign in flow to work. The rest of the Graph SDK consumption should be relegated to a separate package, Microsoft.Toolkit.Graph.Data (or something similar), upon which the other packages can depend on as needed.

Microsoft.Toolkit.Graph.Data

This package will manage how we leverage the Graph SDK and interact with the Graph APIs.

In addition, the Graph SDK occasionally has bugs. A layer of indirection will allow us to workaround any issues while maintaining a consistent usage pattern across the solution.

Describe alternatives you've considered

Additional context & Screenshots

@ghost ghost added the needs triage 🔍 label Mar 2, 2021
@ghost
Copy link

ghost commented Mar 2, 2021

Hello shweaver-MSFT, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@shweaver-MSFT shweaver-MSFT changed the title [Feature] Separate Graph SDK interaction into Data package [Feature] Separate Graph SDK interaction into own package Mar 15, 2021
@ghost ghost added the In-PR 🚀 label Mar 15, 2021
@shweaver-MSFT shweaver-MSFT mentioned this issue Mar 23, 2021
9 tasks
@ghost ghost added Completed 🔥 and removed In-PR 🚀 labels Mar 24, 2021
@shweaver-MSFT
Copy link
Member Author

This was changed in PR #76.

Now the main CommunityToolkit.Net.Authentication package no longer relies on the Graph SDK. All Graph SDK interaction is relegated to the CommunityToolkit.Net.Graph package

@ghost ghost locked as resolved and limited conversation to collaborators Apr 24, 2021
@shweaver-MSFT shweaver-MSFT added this to the 7.1.0 milestone Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant