Request clarification on failing test in Aspire 13 upgrade #947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is upgrading the .NET Aspire Community Toolkit to Aspire 13 preview. A test is reportedly failing, but specific details about which test or error message were not provided.
Investigation findings
Analysis of recent changes shows the NodeJS.Extensions integration underwent refactoring in commit 18787c3 to remove npm functionality (now in Aspire 13 core). The code references:
JavaScriptPackageManagerAnnotation- Expected fromAspire.Hosting.NodeJsnamespaceJavaScriptPackageInstallerAnnotation- Expected fromAspire.Hosting.NodeJsnamespaceJavaScriptInstallerResource- Used for package installationThese types were removed locally and should come from Aspire 13's
Aspire.Hosting.NodeJSpackage, but cannot verify without package restore (network restrictions in sandbox).Next steps
Requested clarification on:
Cannot proceed with fix without ability to build/test locally or access to CI failure details.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.