Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 4, 2025

The PR is upgrading the .NET Aspire Community Toolkit to Aspire 13 preview. A test is reportedly failing, but specific details about which test or error message were not provided.

Investigation findings

Analysis of recent changes shows the NodeJS.Extensions integration underwent refactoring in commit 18787c3 to remove npm functionality (now in Aspire 13 core). The code references:

  • JavaScriptPackageManagerAnnotation - Expected from Aspire.Hosting.NodeJs namespace
  • JavaScriptPackageInstallerAnnotation - Expected from Aspire.Hosting.NodeJs namespace
  • JavaScriptInstallerResource - Used for package installation

These types were removed locally and should come from Aspire 13's Aspire.Hosting.NodeJS package, but cannot verify without package restore (network restrictions in sandbox).

Next steps

Requested clarification on:

  1. Which specific test is failing
  2. Error message from CI logs
  3. Link to failing workflow run

Cannot proceed with fix without ability to build/test locally or access to CI failure details.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Nov 4, 2025
Copy link
Contributor Author

Copilot AI commented Nov 4, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dnceng.pkgs.visualstudio.com
    • Triggering command: dotnet build --no-restore (dns block)
  • k4kvsblobprodcus344.vsblob.vsassets.io
    • Triggering command: dotnet build --no-restore (dns block)
    • Triggering command: dotnet restore (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update packages for Aspire 13 upgrade Request clarification on failing test in Aspire 13 upgrade Nov 4, 2025
Copilot finished work on behalf of aaronpowell November 4, 2025 04:49
Copilot AI requested a review from aaronpowell November 4, 2025 04:49
@aaronpowell aaronpowell closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants