Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data API Builder OTEL doc #388

Open
tommasodotNET opened this issue Jan 14, 2025 · 8 comments
Open

Data API Builder OTEL doc #388

tommasodotNET opened this issue Jan 14, 2025 · 8 comments

Comments

@tommasodotNET
Copy link
Contributor

Page URL

https://learn.microsoft.com/en-us/dotnet/aspire/community-toolkit/hosting-data-api-builder

Describe the issue

Since this PR has been merged, we could improve DAB sample and add some documentation on how to correctly instrument the integration with OTEL.

Suggestion

Example should include OTEL instrumentation and doc should explain how it works

Additional context

No response

Help us help you

Yes, I'd like to be assigned to work on this item

@tommasodotNET
Copy link
Contributor Author

tommasodotNET commented Jan 14, 2025

@aaronpowell should we start updating our readme and then align the official one on ms learn?

@aaronpowell
Copy link
Member

Shouldn't the integration just set that up without you having to do anything?

@tommasodotNET
Copy link
Contributor Author

Yes, but you need to configure the dab-config.json to use otel

@aaronpowell
Copy link
Member

Given that DAB supports layering config files, would it make sense for us to generate that config and add it as "the last" config file that would get loaded?

That way it's not something you have to worry about configuring, it just gets added for you "magically" (and maybe we add an opt-out path if people don't want OTEL enabled)

Copy link

github-actions bot commented Feb 6, 2025

We have noticed this issue has not been updated within 21 days. If there is no action on this issue in the next 14 days, we will automatically close it. You can use /stale-extend to extend the window.

@github-actions github-actions bot added the Stale label Feb 6, 2025
@tommasodotNET
Copy link
Contributor Author

/stale-extend

@github-actions github-actions bot removed the Stale label Feb 6, 2025
Copy link

We have noticed this issue has not been updated within 21 days. If there is no action on this issue in the next 14 days, we will automatically close it. You can use /stale-extend to extend the window.

@aaronpowell
Copy link
Member

We need to work out what the process for doing OTEL into containers is, need to check the internal discussion as it seems there's some challenges still with the SSL certificate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants