Skip to content

[backport cloud/1.36] perf(AssetBrowserModal): virtualize asset grid to reduce network requests #7922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrJKL merged 1 commit into from
Jan 9, 2026
Merged

[backport cloud/1.36] perf(AssetBrowserModal): virtualize asset grid to reduce network requests #7922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/widget/layout/BaseModalLayout.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
{{ contentTitle }}
</h2>
<div
class="min-h-0 px-6 pt-0 pb-10 overflow-y-auto scrollbar-custom"
class="min-h-0 flex-1 px-6 pt-0 pb-10 overflow-y-auto scrollbar-custom"
>
<slot name="content"></slot>
</div>
Expand Down
55 changes: 34 additions & 21 deletions src/platform/assets/components/AssetGrid.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,58 +1,71 @@
<template>
<div
data-component-id="AssetGrid"
:class="
cn('grid grid-cols-[repeat(auto-fill,minmax(15rem,1fr))] gap-4 p-2')
"
class="h-full"
role="grid"
:aria-label="$t('assetBrowser.assetCollection')"
:aria-rowcount="-1"
:aria-colcount="-1"
:aria-setsize="assets.length"
>
<!-- Loading state -->
<div
v-if="loading"
class="col-span-full flex items-center justify-center py-20"
>
<div v-if="loading" class="flex h-full items-center justify-center py-20">
<i
class="icon-[lucide--loader] size-12 animate-spin text-muted-foreground"
/>
</div>
<!-- Empty state -->
<div
v-else-if="assets.length === 0"
class="col-span-full flex flex-col items-center justify-center py-16 text-muted-foreground"
class="flex h-full flex-col items-center justify-center py-16 text-muted-foreground"
>
<i class="mb-4 icon-[lucide--search] size-10" />
<h3 class="mb-2 text-lg font-medium">
{{ $t('assetBrowser.noAssetsFound') }}
</h3>
<p class="text-sm">{{ $t('assetBrowser.tryAdjustingFilters') }}</p>
</div>
<template v-else>
<AssetCard
v-for="asset in assets"
:key="asset.id"
:asset="asset"
:interactive="true"
@select="$emit('assetSelect', $event)"
/>
</template>
<VirtualGrid
v-else
:items="assetsWithKey"
:grid-style="gridStyle"
:default-item-height="320"
:default-item-width="240"
>
<template #item="{ item }">
<AssetCard
:asset="item"
:interactive="true"
@select="$emit('assetSelect', $event)"
/>
</template>
</VirtualGrid>
</div>
</template>

<script setup lang="ts">
import type { CSSProperties } from 'vue'
import { computed } from 'vue'

import VirtualGrid from '@/components/common/VirtualGrid.vue'
import AssetCard from '@/platform/assets/components/AssetCard.vue'
import type { AssetDisplayItem } from '@/platform/assets/composables/useAssetBrowser'
import { cn } from '@/utils/tailwindUtil'

defineProps<{
const { assets } = defineProps<{
assets: AssetDisplayItem[]
loading?: boolean
}>()

defineEmits<{
assetSelect: [asset: AssetDisplayItem]
}>()

const assetsWithKey = computed(() =>
assets.map((asset) => ({ ...asset, key: asset.id }))
)

const gridStyle: Partial<CSSProperties> = {
display: 'grid',
gridTemplateColumns: 'repeat(auto-fill, minmax(15rem, 1fr))',
gap: '1rem',
padding: '0.5rem'
}
</script>
Loading