From 436691da3a544a98a55b474d91bae520e13ee07f Mon Sep 17 00:00:00 2001 From: bymyself Date: Thu, 11 Dec 2025 04:41:09 -0800 Subject: [PATCH 1/2] make legacy prompt dialog test not use snapshot --- browser_tests/tests/interaction.spec.ts | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/browser_tests/tests/interaction.spec.ts b/browser_tests/tests/interaction.spec.ts index 37442bf4e02..14b65ad1424 100644 --- a/browser_tests/tests/interaction.spec.ts +++ b/browser_tests/tests/interaction.spec.ts @@ -306,14 +306,15 @@ test.describe('Node Interaction', () => { await comfyPage.canvas.click({ position: numberWidgetPos }) - await expect(comfyPage.canvas).toHaveScreenshot('prompt-dialog-opened.png') + const legacyPrompt = comfyPage.page.locator('.graphdialog') + await expect(legacyPrompt).toBeVisible() await comfyPage.canvas.click({ position: { x: 10, y: 10 } }) - await expect(comfyPage.canvas).toHaveScreenshot('prompt-dialog-closed.png') + await expect(legacyPrompt).toBeHidden() }) test('Can close prompt dialog with canvas click (text widget)', async ({ @@ -327,18 +328,15 @@ test.describe('Node Interaction', () => { await comfyPage.canvas.click({ position: textWidgetPos }) - await expect(comfyPage.canvas).toHaveScreenshot( - 'prompt-dialog-opened-text.png' - ) + const legacyPrompt = comfyPage.page.locator('.graphdialog') + await expect(legacyPrompt).toBeVisible() await comfyPage.canvas.click({ position: { x: 10, y: 10 } }) - await expect(comfyPage.canvas).toHaveScreenshot( - 'prompt-dialog-closed-text.png' - ) + await expect(legacyPrompt).toBeHidden() }) test('Can double click node title to edit', async ({ comfyPage }) => { From 26ab7c77c59486d4462e08ba5f8a2891a1efaabc Mon Sep 17 00:00:00 2001 From: bymyself Date: Thu, 11 Dec 2025 05:28:32 -0800 Subject: [PATCH 2/2] add back timeout to account for debounce/delay --- browser_tests/tests/interaction.spec.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/browser_tests/tests/interaction.spec.ts b/browser_tests/tests/interaction.spec.ts index 14b65ad1424..451cbffa3d8 100644 --- a/browser_tests/tests/interaction.spec.ts +++ b/browser_tests/tests/interaction.spec.ts @@ -308,6 +308,7 @@ test.describe('Node Interaction', () => { }) const legacyPrompt = comfyPage.page.locator('.graphdialog') await expect(legacyPrompt).toBeVisible() + await comfyPage.delay(300) await comfyPage.canvas.click({ position: { x: 10, @@ -330,6 +331,7 @@ test.describe('Node Interaction', () => { }) const legacyPrompt = comfyPage.page.locator('.graphdialog') await expect(legacyPrompt).toBeVisible() + await comfyPage.delay(300) await comfyPage.canvas.click({ position: { x: 10,