fix wrong 3d node def after refactor #7054
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtydhr88
requested review from
a team,
KarryCharon,
Yorha4D and
shinshin86
as code owners
dosubot
bot
added
the
size:M
Contributor
📝 WalkthroughWalkthroughNode definitions in the English locale file are refactored to consolidate 3D-related nodes. Load3D and Preview3D nodes have updated display names reflecting combined functionality, while their separate animation-specific counterpart nodes (Load3DAnimation and Preview3DAnimation) are removed entirely. Changes
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
🎭 Playwright Test Results⏰ Completed at: 11/30/2025, 02:13:52 PM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 11/30/2025, 02:05:18 PM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.18 MB (baseline 3.18 MB) • 🟢 -768 BMain entry bundles and manifests
Status: 3 added / 3 removed Graph Workspace — 950 kB (baseline 950 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 6.54 kB (baseline 6.54 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed Panels & Settings — 298 kB (baseline 298 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed UI Components — 139 kB (baseline 139 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed Data & Services — 12.5 kB (baseline 12.5 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed Utilities & Hooks — 2.94 kB (baseline 2.94 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 1 added / 1 removed Vendor & Third-Party — 8.56 MB (baseline 8.56 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 3.84 MB (baseline 3.84 MB) • ⚪ 0 BBundles that do not match a named category
Status: 17 added / 17 removed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/locales/en/nodeDefs.json (1)
8989-9001: Preview label consistency“Preview 3D & Animation” keeps UX terminology consistent with Load3D after the merge. Consider a brief description/tooltip noting it previews both static 3D and animations. (github.com)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/locales/en/nodeDefs.json(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: lint-and-format
- GitHub Check: setup
- GitHub Check: collect
- GitHub Check: test
🔇 Additional comments (1)
src/locales/en/nodeDefs.json (1)
4802-4839: EN locale correctly reflects merged node; non-English locales retain stale animation entriesThe Load 3D & Animation and Preview 3D & Animation display names are correctly updated in the English locale. The output signature (image, mask, mesh_path, normal, camera_info, recording_video) matches the merged backend node with lineart properly omitted. However, non-English locale files (zh, fr, es, tr, ru, ko, ja, ar, zh-TW) still contain separate Load3DAnimation and Preview3DAnimation node definitions that should be removed or merged to align with the backend consolidation. Consider a follow-up PR to clean up these stale entries across all locales, or verify whether this PR intentionally leaves them for backward-compatibility with the runtime migration code in src/scripts/app.ts.
Contributor
christian-byrne
left a comment
christian-byrne
left a comment
There was a problem hiding this comment.
This usually happens automatically, but the locale generation workflow is currently broken.
Collaborator
Author
|
@christian-byrne on currect version of core, it is still missing these changes |
DrJKL
approved these changes
Nov 30, 2025
Contributor
|
When do you think we'll have the locale workflow working again? |
Contributor
|
We shouldn't manually edit these files really, it may disrupt the CI/CD. Only if ths current translations are breaking the node. |
Collaborator
Author
|
Ok, @christian-byrne let me close this. But as you mentioned, current GitHub workflow is down, just let me know when it is available, I will double check this issue to fix later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix wrong node def for 3d load after refactor, to match BE change in comfyanonymous/ComfyUI#10025
┆Issue is synchronized with this Notion page by Unito