Skip to content

[ci] collapsible sections in ci size report comments #6118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christian-byrne merged 1 commit into from
Oct 19, 2025
Merged

[ci] collapsible sections in ci size report comments #6118

christian-byrne merged 1 commit into from
Oct 19, 2025

Conversation

@christian-byrne
Copy link
Contributor

@christian-byrne christian-byrne commented Oct 18, 2025 •
edited by sync-by-unito bot
Loading

Summary

Adjust size reporting scripts to aggregate baseline/current metrics, render collapsible GitHub-friendly tables using <details>, and expanded bundle categorisation heuristics

┆Issue is synchronized with this Notion page by Unito

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Oct 18, 2025
@github-actions
Copy link

github-actions bot commented Oct 18, 2025 •
edited
Loading

🎭 Playwright Test Results

❌ Some tests failed

⏰ Completed at: 10/18/2025, 08:34:59 AM UTC

📈 Summary

  • Total Tests: 497
  • Passed: 463 ✅
  • Failed: 1 ❌
  • Flaky: 3 ⚠️
  • Skipped: 30 ⏭️

📊 Test Reports by Browser

  • ✅ chromium: View Report • ✅ 454 / ❌ 1 / ⚠️ 3 / ⏭️ 30
  • ✅ chromium-2x: View Report • ✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ chromium-0.5x: View Report • ✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0
  • ✅ mobile-chrome: View Report • ✅ 6 / ❌ 0 / ⚠️ 0 / ⏭️ 0

🎉 Click on the links above to view detailed test results for each browser configuration.

@github-actions
Copy link

github-actions bot commented Oct 18, 2025 •
edited
Loading

🎨 Storybook Build Status

✅ Build completed successfully!

⏰ Completed at: 10/18/2025, 08:19:43 AM UTC

🔗 Links

🎉 Your Storybook is ready for review!

@christian-byrne
Copy link
Contributor Author

christian-byrne commented Oct 18, 2025

(This PR is made by Claude).

@github-actions
Copy link

github-actions bot commented Oct 18, 2025

Bundle Size Report

App Entry Points

Main application bundles

File Size Gzip Brotli
assets/index-Dxw6d55T.js 9.67 MB 1.99 MB 1.43 MB
assets/index-MgVpi94-.js 2.02 MB 381 kB 296 kB
assets/index-PESgPnbc.js 507 B 292 B 249 B

Category Total: 11.7 MB

UI Components

Reusable UI components

File Size Gzip Brotli
assets/UserAvatar.vue_vue_type_script_setup_true_lang-C9bSkTC5.js 1.12 kB 577 B 494 B

Category Total: 1.12 kB

Panels & Settings

File Size Gzip Brotli
assets/AboutPanel-BmgJ3RUl.js 10.1 kB 2.58 kB 2.27 kB
assets/CreditsPanel-Onm11UFv.js 21.9 kB 5.21 kB 4.54 kB
assets/ExtensionPanel-DbpMns0L.js 11.9 kB 2.74 kB 2.4 kB
assets/KeybindingPanel-iZYgTzSz.js 15.1 kB 3.68 kB 3.24 kB
assets/ServerConfigPanel-DMbHcgPk.js 8.04 kB 2.08 kB 1.84 kB
assets/UserPanel-C8zzJKSe.js 7.76 kB 1.98 kB 1.72 kB

Category Total: 74.8 kB

Graph Workspace

File Size Gzip Brotli
assets/GraphView-D8od12x4.js 713 kB 139 kB 108 kB

Category Total: 713 kB

Views & Navigation

File Size Gzip Brotli
assets/UserSelectView-BvzxtqjF.js 7.99 kB 2.4 kB 2.1 kB

Category Total: 7.99 kB

Data & Services

File Size Gzip Brotli
assets/keybindingService-3V_cl3Da.js 7.21 kB 1.75 kB 1.5 kB
assets/serverConfigStore-DK_B3JiC.js 2.79 kB 891 B 782 B

Category Total: 10 kB

Utilities & Hooks

File Size Gzip Brotli
assets/mathUtil-CTARWQ-l.js 1.07 kB 525 B 452 B

Category Total: 1.07 kB

Overall Total Size: 12.5 MB
Total Bundle Count: 15

DrJKL
DrJKL reviewed Oct 18, 2025
View reviewed changes
scripts/bundle-categories.js
/Graph(View|State)?-.*\.js$/i,
/(Canvas|Workflow|History|NodeGraph|Compositor)-.*\.js$/i
],
order: 2
Copy link
Contributor

@DrJKL DrJKL Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little late, but it might be worth incrementing by 5 or 10 in the beginning to make insertions easier later.

DrJKL
DrJKL reviewed Oct 18, 2025
View reviewed changes
scripts/size-report.js
Copy link
Contributor

@DrJKL DrJKL Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we convert the scripts to TS?

DrJKL
DrJKL approved these changes Oct 18, 2025
View reviewed changes
Copy link
Contributor

@DrJKL DrJKL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Didn't review thoroughly)

@christian-byrne christian-byrne merged commit d83e34d into main Oct 19, 2025
30 of 31 checks passed
@christian-byrne christian-byrne deleted the ci/improve-size-report-categories branch October 19, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrJKL DrJKL DrJKL approved these changes

@LittleSound LittleSound Awaiting requested review from LittleSound

Assignees

No one assigned

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christian-byrne @DrJKL