Skip to content

Conversation

@DrJKL
Copy link
Contributor

@DrJKL DrJKL commented Sep 4, 2025

Summary

Re-add caching of browsers.
Fixes #5348 (hopefully)

Changes

  • What: Caches playwright browser installs per playwright version
    They discourage it but in practice it looks like networking is an issue for us when sharding.

Review Focus

Standard GitHub Actions things, what weird little edge cases did I forget about this time?

┆Issue is synchronized with this Notion page by Unito

@DrJKL DrJKL requested a review from a team as a code owner September 4, 2025 18:30
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 4, 2025
@github-actions
Copy link

github-actions bot commented Sep 4, 2025

🎭 Playwright Test Results

All tests passed across all browsers!

⏰ Completed at: 09/04/2025, 06:57:15 PM UTC

📊 Test Reports by Browser


🎉 Your tests are passing across all browsers!

Copy link
Contributor

@webfiltered webfiltered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrJKL DrJKL merged commit 58313ea into main Sep 4, 2025
35 checks passed
@DrJKL DrJKL deleted the drjkl/playwright-caching branch September 4, 2025 19:18
@benceruleanlu benceruleanlu mentioned this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Playwright sharded - cache issues

4 participants