Skip to content

Commit 77a447c

Browse files
author
duckcomfy
committed
fix: do not register default keybinds for moving selected nodes
Let user set their own, otherwise the experience might be too jarring to start happening suddenly. refactor: await the disregarded promise instead of voiding it (code unrelated to this PR, but the change was required by ESLint.)
1 parent 08f6457 commit 77a447c

File tree

2 files changed

+2
-34
lines changed

2 files changed

+2
-34
lines changed

browser_tests/fixtures/ComfyPage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,7 @@ export class ComfyPage {
762762
y: 625
763763
}
764764
})
765-
void this.page.mouse.move(10, 10)
765+
await this.page.mouse.move(10, 10)
766766
await this.nextFrame()
767767
}
768768

@@ -774,7 +774,7 @@ export class ComfyPage {
774774
},
775775
button: 'right'
776776
})
777-
void this.page.mouse.move(10, 10)
777+
await this.page.mouse.move(10, 10)
778778
await this.nextFrame()
779779
}
780780

src/constants/coreKeybindings.ts

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -173,37 +173,5 @@ export const CORE_KEYBINDINGS: Keybinding[] = [
173173
key: 'f'
174174
},
175175
commandId: 'Workspace.ToggleFocusMode'
176-
},
177-
{
178-
combo: {
179-
ctrl: true,
180-
key: 'ArrowUp'
181-
},
182-
commandId: 'Comfy.Canvas.MoveSelectedNodes.Up',
183-
targetElementId: 'graph-canvas'
184-
},
185-
{
186-
combo: {
187-
ctrl: true,
188-
key: 'ArrowDown'
189-
},
190-
commandId: 'Comfy.Canvas.MoveSelectedNodes.Down',
191-
targetElementId: 'graph-canvas'
192-
},
193-
{
194-
combo: {
195-
ctrl: true,
196-
key: 'ArrowLeft'
197-
},
198-
commandId: 'Comfy.Canvas.MoveSelectedNodes.Left',
199-
targetElementId: 'graph-canvas'
200-
},
201-
{
202-
combo: {
203-
ctrl: true,
204-
key: 'ArrowRight'
205-
},
206-
commandId: 'Comfy.Canvas.MoveSelectedNodes.Right',
207-
targetElementId: 'graph-canvas'
208176
}
209177
]

0 commit comments

Comments
 (0)