Stable 1.82.11 Hotfix (#651)

# What's new? - 1.82.11
- **[New]** Toggle "Playing" Discord RPC status per-region, by @bagusnl 
- You can disable "Playing" status per-region now by going to Quick
Settings (bottom right on Homepage) and toggling it off.
  - This is enabled by default (as it always is)
- **[Fix]** Bloated Sophon pre-download/update size due to duplicate
entries, by @neon-nyan
- **[Imp]** Match API requests headers, by @neon-nyan 
- **[Fix]** Cannot copy error message caused by ``HGlobal`` buffer
misallocation for some users, by @neon-nyan
- **[Fix]** IOSharingViolation due to file/directory handling in some
methods, by @neon-nyan
- **[Fix]** Repair causing application crashes due to value overflow, by
@bagusnl
- **[Fix]** Game installation error due to invalid VO language
selection, by @neon-nyan
- **[Imp]** Sentry improvements, by @bagusnl 
  - Filter exceptions to be sent
    + Exceptions caused by users' internet situation are filtered
  - Add loaded modules info to breadcrumb
  - Detach inner exception handler method
- **[Imp]** Sophon Download Improvements, by @neon-nyan 
- Adding disk-space check on Game Installation/Update and Pre-load
Download.
  - Ignore if VO's LanguageString is not valid on non-debug build
  - Separate Sophon methods to its own code files
- **[Imp]** UI/UX Improvements, by @shatyuka @neon-nyan and @bagusnl 
- New fallback background when the background sprite is not yet
downloaded
> The official HoYoPlay's default background is used for the fallback
background
  - Disable some tab focus within the PostPanel
  - Resize Pivot header in PostPanel
  - Make ScrollViewer receive focus as a whole
  - Enable navigation via arrow keys in ScrollViewer
- Adjust Audio-related setting's Grid layout on Genshin Game Settings
Page
- **[Fix]** DB sync buttons on App Settings page doesn't get disabled
when the toggle is off
- **[Loc]** Localization Sync from Transifex, by Localizers <3

### Templates

<details>
  <summary>Changelog Prefixes</summary>
  
  ```
    **[New]**
    **[Imp]**
    **[Fix]**
    **[Loc]**
    **[Doc]**
  ```

</details>

Author: neon-nyan

.github/workflows/qodana-scan-pr.yml

@@ -3,6 +3,8 @@ on:
  pull_request:
    branches:
      - main
+     - preview
+     - stable
 
 jobs:
   qodana:

CollapseLauncher/App.xaml

@@ -1,4 +1,5 @@
-using CollapseLauncher.Interfaces;
+using CollapseLauncher.Helper;
+using CollapseLauncher.Interfaces;
 using Hi3Helper;
 using System;
 using System.Collections.Generic;
@@ -57,19 +58,31 @@ private async Task<List<CacheAsset>> Check(List<CacheAsset> assetIndex, Cancella
 
         private void CheckUnusedAssets(List<CacheAsset> assetIndex, List<CacheAsset> returnAsset)
         {
+            // Directory info and if the directory doesn't exist, return
+            DirectoryInfo directoryInfo = new DirectoryInfo(_gamePath);
+            if (!directoryInfo.Exists)
+            {
+                return;
+            }
+
             // Iterate the file contained in the _gamePath
-            foreach (string filePath in Directory.EnumerateFiles(_gamePath!, "*", SearchOption.AllDirectories))
+            foreach (FileInfo fileInfo in directoryInfo.EnumerateFiles("*", SearchOption.AllDirectories)
+                .EnumerateNoReadOnly())
             {
-                if (!filePath.Contains("output_log") && !filePath.Contains("Crashes")
-                 && !filePath.Contains("Verify.txt") && !filePath.Contains("APM")
-                 && !filePath.Contains("FBData") && !filePath.Contains("asb.dat")
-                 && !assetIndex!.Exists(x => x!.ConcatPath == filePath))
+                string filePath = fileInfo.FullName;
+
+                if (!filePath.Contains("output_log", StringComparison.OrdinalIgnoreCase)
+                 && !filePath.Contains("Crashes", StringComparison.OrdinalIgnoreCase)
+                 && !filePath.Contains("Verify.txt", StringComparison.OrdinalIgnoreCase)
+                 && !filePath.Contains("APM", StringComparison.OrdinalIgnoreCase)
+                 && !filePath.Contains("FBData", StringComparison.OrdinalIgnoreCase)
+                 && !filePath.Contains("asb.dat", StringComparison.OrdinalIgnoreCase)
+                 && !assetIndex.Exists(x => x.ConcatPath == fileInfo.FullName))
                 {
                     // Increment the total found count
                     _progressAllCountFound++;
 
                     // Add asset to the returnAsset
-                    FileInfo fileInfo = new FileInfo(filePath);
                     CacheAsset asset = new CacheAsset()
                     {
                         BasePath = Path.GetDirectoryName(filePath),
@@ -106,10 +119,10 @@ private async ValueTask CheckAsset(CacheAsset asset, List<CacheAsset> returnAsse
             _status.ActivityAll = string.Format(Lang._CachesPage.CachesTotalStatusChecking!, _progressAllCountCurrent, _progressAllCountTotal);
 
             // Assign the file info.
-            FileInfo fileInfo = new FileInfo(asset.ConcatPath!);
+            FileInfo fileInfo = new FileInfo(asset.ConcatPath).EnsureNoReadOnly(out bool isExist);
 
             // Check if the file exist. If not, then add it to asset index.
-            if (!fileInfo.Exists)
+            if (!isExist)
             {
                 AddGenericCheckAsset(asset, CacheAssetStatus.New, returnAsset, null, asset.CRCArray);
                 return;

CollapseLauncher/Assets/Images/GameBackground/genshin.webp

@@ -126,12 +126,12 @@ private async Task UpdateCacheAsset((CacheAsset AssetIndex, IAssetProperty Asset
 
             FileInfo fileInfo = new FileInfo(asset.AssetIndex.ConcatPath!)
                                .EnsureCreationOfDirectory()
-                               .EnsureNoReadOnly();
+                               .EnsureNoReadOnly(out bool isExist);
 
             // This is a action for Unused asset.
             if (asset.AssetIndex.DataType == CacheAssetType.Unused)
             {
-                if (fileInfo.Exists)
+                if (isExist)
                     fileInfo.Delete();
 
                 LogWriteLine($"Deleted unused file: {fileInfo.FullName}", LogType.Default, true);

CollapseLauncher/Assets/Images/GameBackground/honkai.webp

@@ -1,4 +1,5 @@
-using Hi3Helper;
+using CollapseLauncher.Helper;
+using Hi3Helper;
 using Hi3Helper.EncTool.Parser.AssetMetadata.SRMetadataAsset;
 using System;
 using System.Collections.Generic;
@@ -79,12 +80,12 @@ private async ValueTask CheckAsset(SRAsset asset, List<SRAsset> returnAsset, str
             }
 
             // Get persistent and streaming paths
-            FileInfo fileInfoPersistent = new FileInfo(Path.Combine(basePersistent!, asset.LocalName!));
-            FileInfo fileInfoStreaming = new FileInfo(Path.Combine(baseStreaming!, asset.LocalName!));
+            FileInfo fileInfoPersistent = new FileInfo(Path.Combine(basePersistent!, asset.LocalName!)).EnsureNoReadOnly(out bool isPersistentExist);
+            FileInfo fileInfoStreaming = new FileInfo(Path.Combine(baseStreaming!, asset.LocalName!)).EnsureNoReadOnly(out bool isStreamingExist);
 
-            bool UsePersistent = !fileInfoStreaming.Exists;
-            bool IsPersistentExist = fileInfoPersistent.Exists && fileInfoPersistent.Length == asset.Size;
-            bool IsStreamingExist = fileInfoStreaming.Exists && fileInfoStreaming.Length == asset.Size;
+            bool UsePersistent = !isStreamingExist;
+            bool IsPersistentExist = isPersistentExist && fileInfoPersistent.Length == asset.Size;
+            bool IsStreamingExist = isStreamingExist && fileInfoStreaming.Length == asset.Size;
             asset.LocalName = UsePersistent ? fileInfoPersistent.FullName : fileInfoStreaming.FullName;
 
             // Check if the file exist. If not, then add it to asset index.

CollapseLauncher/Assets/Images/GameBackground/starrail.webp

@@ -6,8 +6,8 @@
 #nullable enable
 namespace CollapseLauncher.Extension
 {
-    internal delegate Task<TResult?> ActionTimeoutValueTaskCallback<TResult>(CancellationToken token);
-    internal delegate void ActionOnTimeOutRetry(int retryAttemptCount, int retryAttemptTotal, int timeOutSecond, int timeOutStep);
+    public delegate Task<TResult?> ActionTimeoutValueTaskCallback<TResult>(CancellationToken token);
+    public delegate void ActionOnTimeOutRetry(int retryAttemptCount, int retryAttemptTotal, int timeOutSecond, int timeOutStep);
     internal static class TaskExtensions
     {
         internal const int DefaultTimeoutSec = 10;

CollapseLauncher/Assets/Images/GameBackground/zzz.webp

@@ -162,7 +162,7 @@ private static bool IsCollapseProgramPath(ReadOnlySpan<char> path)
         /// </summary>
         /// <param name="path">Path to check</param>
         /// <returns>True if path is root of the drive</returns>
-        internal static bool IsRootPath(ReadOnlySpan<char> path)
+        public static bool IsRootPath(ReadOnlySpan<char> path)
         {
             ReadOnlySpan<char> rootPath = Path.GetPathRoot(path);
             return rootPath.SequenceEqual(path);

CollapseLauncher/Classes/CachesManagement/Honkai/Check.cs

@@ -90,20 +90,25 @@ private async Task<string> StartRoutineInner(FileMigrationProcessUIRef uiRef)
 
         private async Task<string> MoveFile(FileMigrationProcessUIRef uiRef)
         {
-            FileInfo inputPathInfo = new FileInfo(this.inputPath!);
-            FileInfo outputPathInfo = new FileInfo(this.outputPath!);
+            FileInfo inputPathInfo = new FileInfo(inputPath);
+            FileInfo outputPathInfo = new FileInfo(outputPath);
 
-            string inputPathDir = Path.GetDirectoryName(inputPathInfo.FullName);
-            string outputPathDir = Path.GetDirectoryName(outputPathInfo.FullName);
+            var inputPathDir = FileDialogHelper.IsRootPath(inputPath)
+                ? Path.GetPathRoot(inputPath)
+                : Path.GetDirectoryName(inputPathInfo.FullName);
 
-            if (!Directory.Exists(outputPathDir))
-                Directory.CreateDirectory(outputPathDir!);
+            if (string.IsNullOrEmpty(inputPathDir))
+                throw new InvalidOperationException(string.Format(Locale.Lang._Dialogs.InvalidGameDirNewTitleFormat,
+                                                                  inputPath));
+            
+            DirectoryInfo outputPathDirInfo = new DirectoryInfo(inputPathDir);
+            outputPathDirInfo.Create();
 
             // Update path display
             string inputFileBasePath = inputPathInfo.FullName.Substring(inputPathDir!.Length + 1);
             UpdateCountProcessed(uiRef, inputFileBasePath);
 
-            if (this.IsSameOutputDrive)
+            if (IsSameOutputDrive)
             {
                 Logger.LogWriteLine($"[FileMigrationProcess::MoveFile()] Moving file in the same drive from: {inputPathInfo.FullName} to {outputPathInfo.FullName}", LogType.Default, true);
                 inputPathInfo.MoveTo(outputPathInfo.FullName, true);
@@ -112,29 +117,27 @@ private async Task<string> MoveFile(FileMigrationProcessUIRef uiRef)
             else
             {
                 Logger.LogWriteLine($"[FileMigrationProcess::MoveFile()] Moving file across different drives from: {inputPathInfo.FullName} to {outputPathInfo.FullName}", LogType.Default, true);
-                await MoveWriteFile(uiRef, inputPathInfo, outputPathInfo, this.tokenSource == null ? default : this.tokenSource.Token);
+                await MoveWriteFile(uiRef, inputPathInfo, outputPathInfo, tokenSource == null ? default : tokenSource.Token);
             }
 
             return outputPathInfo.FullName;
         }
 
         private async Task<string> MoveDirectory(FileMigrationProcessUIRef uiRef)
         {
-            DirectoryInfo inputPathInfo = new DirectoryInfo(this.inputPath!);
-            if (!Directory.Exists(this.outputPath))
-                Directory.CreateDirectory(this.outputPath!);
-
-            DirectoryInfo outputPathInfo = new DirectoryInfo(this.outputPath);
+            DirectoryInfo inputPathInfo = new DirectoryInfo(inputPath);
+            DirectoryInfo outputPathInfo = new DirectoryInfo(outputPath);
+            outputPathInfo.Create();
 
             int parentInputPathLength = inputPathInfo.Parent!.FullName.Length + 1;
             string outputDirBaseNamePath = inputPathInfo.FullName.Substring(parentInputPathLength);
-            string outputDirPath = Path.Combine(this.outputPath, outputDirBaseNamePath);
+            string outputDirPath = Path.Combine(outputPath, outputDirBaseNamePath);
 
             await Parallel.ForEachAsync(
                 inputPathInfo.EnumerateFiles("*", SearchOption.AllDirectories),
                 new ParallelOptions
                 {
-                    CancellationToken = this.tokenSource?.Token ?? default,
+                    CancellationToken = tokenSource?.Token ?? default,
                     MaxDegreeOfParallelism = LauncherConfig.AppCurrentThread
                 },
                 async (inputFileInfo, cancellationToken) =>
@@ -146,10 +149,14 @@ await Parallel.ForEachAsync(
                     UpdateCountProcessed(uiRef, inputFileBasePath);
 
                     string outputTargetPath = Path.Combine(outputPathInfo.FullName, inputFileBasePath);
-                    string outputTargetDirPath = Path.GetDirectoryName(outputTargetPath);
-
-                    if (!Directory.Exists(outputTargetDirPath))
-                        Directory.CreateDirectory(outputTargetDirPath!);
+                    string outputTargetDirPath = Path.GetDirectoryName(outputTargetPath) ?? Path.GetPathRoot(outputTargetPath);
+
+                    if (string.IsNullOrEmpty(outputTargetDirPath)) 
+                        throw new InvalidOperationException(string.Format(Locale.Lang._Dialogs.InvalidGameDirNewTitleFormat,
+                                                                          inputPath));
+                    
+                    DirectoryInfo outputTargetDirInfo = new DirectoryInfo(outputTargetDirPath);
+                    outputTargetDirInfo.Create();
 
                     if (this.IsSameOutputDrive)
                     {

CollapseLauncher/Classes/CachesManagement/Honkai/Update.cs

@@ -17,13 +17,13 @@ private async Task MoveWriteFile(FileMigrationProcessUIRef uiRef, FileInfo input
         {
             int bufferSize = 1 << 18; // 256 kB Buffer
 
-            if (inputFile!.Length < bufferSize)
+            if (inputFile.Length < bufferSize)
                 bufferSize = (int)inputFile.Length;
 
             byte[] buffer = new byte[bufferSize];
 
             await using (FileStream inputStream = inputFile.OpenRead())
-                await using (FileStream outputStream = outputFile!.Exists && outputFile.Length <= inputFile.Length ?
+                await using (FileStream outputStream = outputFile.Exists && outputFile.Length <= inputFile.Length ?
                                  outputFile.Open(FileMode.Open) : outputFile.Create())
                 {
                     // Set the output file size to inputStream's if the length is more than inputStream

CollapseLauncher/Classes/CachesManagement/StarRail/Check.cs

@@ -116,6 +116,11 @@ public bool UseCustomRegionBG
         /// Determines if the game playtime should be synced to the database
         /// </summary>
         public bool IsSyncPlaytimeToDatabase { get; set; } = true;
+        
+        /// <summary>
+        /// Set per-region Discord Rich Presence setting for playing status
+        /// </summary>
+        public bool IsPlayingRpc { get; set; } = true;
 
         #endregion
 

CollapseLauncher/Classes/Extension/TaskExtensions.cs

@@ -66,7 +66,7 @@ internal enum MediaType
         {
             try
             {
-                await action.ConfigureAwait(false);
+                await action;
             }
             catch (Exception ex)
             {

CollapseLauncher/Classes/FileDialog/FileDialogHelper.cs

@@ -1,6 +1,7 @@
 using CollapseLauncher.Helper.Update;
 using Hi3Helper.Shared.Region;
 using System;
+using System.Collections.Generic;
 using System.Diagnostics;
 using System.Net;
 using System.Net.Http;
@@ -17,21 +18,22 @@ public class HttpClientBuilder : HttpClientBuilder<SocketsHttpHandler>;
         private const int _maxConnectionsDefault = 32;
         private const double _httpTimeoutDefault = 90; // in Seconds
 
-        private bool IsUseProxy { get; set; } = true;
-        private bool IsUseSystemProxy { get; set; } = true;
+        private bool IsUseProxy              { get; set; } = true;
+        private bool IsUseSystemProxy        { get; set; } = true;
         private bool IsAllowHttpRedirections { get; set; }
-        private bool IsAllowHttpCookies { get; set; }
-        private bool IsAllowUntrustedCert { get; set; }
-
-        private int                  MaxConnections      { get; set; } = _maxConnectionsDefault;
-        private DecompressionMethods DecompressionMethod { get; set; } = DecompressionMethods.All;
-        private WebProxy?            ExternalProxy       { get; set; }
-        private Version              HttpProtocolVersion { get; set; } = HttpVersion.Version30;
-        private string?              HttpUserAgent       { get; set; } = GetDefaultUserAgent();
-        private string?              HttpAuthHeader      { get; set; }
-        private HttpVersionPolicy HttpProtocolVersionPolicy { get; set; } = HttpVersionPolicy.RequestVersionOrLower;
-        private TimeSpan          HttpTimeout               { get; set; } = TimeSpan.FromSeconds(_httpTimeoutDefault);
-        private Uri?              HttpBaseUri               { get; set; }
+        private bool IsAllowHttpCookies      { get; set; }
+        private bool IsAllowUntrustedCert    { get; set; }
+
+        private int                         MaxConnections            { get; set; } = _maxConnectionsDefault;
+        private DecompressionMethods        DecompressionMethod       { get; set; } = DecompressionMethods.All;
+        private WebProxy?                   ExternalProxy             { get; set; }
+        private Version                     HttpProtocolVersion       { get; set; } = HttpVersion.Version30;
+        private string?                     HttpUserAgent             { get; set; } = GetDefaultUserAgent();
+        private string?                     HttpAuthHeader            { get; set; }
+        private HttpVersionPolicy           HttpProtocolVersionPolicy { get; set; } = HttpVersionPolicy.RequestVersionOrLower;
+        private TimeSpan                    HttpTimeout               { get; set; } = TimeSpan.FromSeconds(_httpTimeoutDefault);
+        private Uri?                        HttpBaseUri               { get; set; }
+        private Dictionary<string, string?> HttpHeaders               { get; set; } = new(StringComparer.OrdinalIgnoreCase);
 
         public HttpClientBuilder<THandler> UseProxy(bool isUseSystemProxy = true)
         {
@@ -191,6 +193,34 @@ public HttpClientBuilder<THandler> SetBaseUrl(Uri baseUrl)
             return this;
         }
 
+        public HttpClientBuilder<THandler> AddHeader(string key, string? value)
+        {
+            // Throw if the key is null or empty
+            ArgumentException.ThrowIfNullOrEmpty(key, nameof(key));
+
+            // Try check if the key is user-agent. If the user-agent has already
+            // been set, then override the value from HttpUserAgent property
+            if (key.Equals("User-Agent", StringComparison.OrdinalIgnoreCase))
+            {
+                HttpUserAgent = null;
+            }
+
+            // If the key already exist, then override the previous one.
+            // Otherwise, add the new key-value pair
+            // ReSharper disable once RedundantDictionaryContainsKeyBeforeAdding
+            if (HttpHeaders.ContainsKey(key))
+            {
+                HttpHeaders[key] = value;
+            }
+            else
+            {
+                HttpHeaders.Add(key, value);
+            }
+
+            // Return the instance of the builder
+            return this;
+        }
+
         public HttpClient Create()
         {
             // Create the instance of the handler
@@ -273,6 +303,12 @@ public HttpClient Create()
             if (!string.IsNullOrEmpty(HttpAuthHeader))
                 client.DefaultRequestHeaders.Add("Authorization", HttpAuthHeader);
 
+            // Add other headers
+            foreach (KeyValuePair<string, string?> header in HttpHeaders)
+            {
+                _ = client.DefaultRequestHeaders.TryAddWithoutValidation(header.Key, header.Value);
+            }
+
             return client;
         }
     }