Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'disabled' paper-bottom-sheet-item still sends events such as on-tap #5

Closed
ankon opened this issue Aug 2, 2016 · 2 comments
Closed

Comments

@ankon
Copy link
Contributor

ankon commented Aug 2, 2016

<paper-bottom-sheet-item text="Foo" disabled on-tap="handleTapFoo"></paper-bottom-sheet-item>

I'd expect handleTapFoo not to be called on taps, as the component is disabled. Not sure whether that is a problem in the paper-bottom-sheet-item itself, or just something that needs to be handled more globally in polymer.

For now I'm working around this by checking the disabled state in handleTapFoo.

@srijken
Copy link
Contributor

srijken commented Jun 26, 2018

This may have been fixed by this issue: Polymer/polymer#4685

Does this still happen?

@ankon
Copy link
Contributor Author

ankon commented Jun 30, 2018

I'm not sure really, I think I lost that code that needed it in a redesign. The issue you link to looks indeed related, so without further evidence of the problem I'll close this ticket. If needed it can be reopened :)

Thanks a lot for the reference!

@ankon ankon closed this as completed Jun 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants