Skip to content

Conversation

@SebastianSpeitel
Copy link
Contributor

No description provided.

"scripts": {
"pretest": "npm run asbuild:empty",
"test": "asp --verbose --nologo && npm run test:empty",
"pretest:empty": "npm run asbuild:empty",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this work, you may ask.

pre and post hooks can be added to any npm script by just prefixing it with pre or post.
https://docs.npmjs.com/cli/v7/using-npm/scripts#pre--post-scripts

@SebastianSpeitel SebastianSpeitel marked this pull request as ready for review May 6, 2021 17:14
@SebastianSpeitel SebastianSpeitel marked this pull request as draft May 6, 2021 17:46
@SebastianSpeitel
Copy link
Contributor Author

SebastianSpeitel commented May 6, 2021

Since this now tests an optimized build, even neither inlining nor marking as @lazy will fail now, since binaryan omits unused variables during optimization.

And not optimizing won't result in an empty output because i32.MAX_VALUE will be emitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant