MPRIS2 Pause should only pause, not be a toggle and play if already paused

[scotte]

Description:

MellowPlayer treats the MPRIS2 Pause command the same as PlayPause. In MPRIS2, Pause should only pause if playing, but not play if already paused - PlayPause is for that purpose.

Specification reference: https://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html

Specifically:

Pause () → nothing
Pauses playback.
If playback is already paused, this has no effect.

and:

PlayPause () → nothing
Pauses playback.
If playback is already paused, resumes playback.
If playback is stopped, starts playback.

Steps To Reproduce:

1. dbus-send --print-reply --dest=org.mpris.MediaPlayer2.MellowPlayer /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.Pause

Running this command when the player is paused will start playback. This should not happen for "Pause".

Additional Information:

• Version: 3.3.5.0
• Affected streaming services (if any): Google Play Music (tested, may affect others)
• Operating System: Ubuntu Bionic 4.15.0-22-generic, i3wm (no desktop environment)

mellowplayer:
  Installed: 3.3.5-1
  Candidate: 3.3.5-1
  Version table:
 *** 3.3.5-1 500
        500 http://download.opensuse.org/repositories/home:/ColinDuquesnoy/xUbuntu_17.10  Packages
        100 /var/lib/dpkg/status

[ColinDuquesnoy]

Thank you for reporting the issue! The implementation of Pause (and Play) is fixed in the develop branch (you can check it out by running the AppImage of the next Continuous build)

[scotte]

Thank you! That was quick. :-)

[scotte]

Meant to follow up a couple of days back and report that all is working as expected in the continuous built AppImage. Thanks again!