Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/zigzag #11

Closed
wants to merge 27 commits into from
Closed

Feat/zigzag #11

wants to merge 27 commits into from

Conversation

james-hummingbot
Copy link

@james-hummingbot james-hummingbot commented Mar 24, 2023 •
edited by vic-en
Loading

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
This pr adds the a Zigzag connector which connector to the Zigzag contract on Arbitrum.
[ch 37878]

Tests performed by the developer:

  • Curl tests
  • Unit tests
  • End-to end testing between client and Gateway.

Tips for QA testing:

  • Perform curl tests using newly added curl commands in this pr.
  • Perform end-to end testing between client and Gateway.

@geneuinely07
Copy link
Collaborator

[sc-37878]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #37878: Create ZigZag connector in Gateway.

@vic-en vic-en self-assigned this Mar 30, 2023
@vic-en vic-en marked this pull request as ready for review March 30, 2023 23:00
@vic-en vic-en requested review from petioptrv and PtrckM March 30, 2023 23:05
@geneuinely07 geneuinely07 removed the request for review from PtrckM March 31, 2023 02:07
@geneuinely07 geneuinely07 requested a review from a team March 31, 2023 02:30
@rxlxrxsx
Copy link

rxlxrxsx commented Mar 31, 2023 •
edited
Loading

Test run:

Gateway - https://hummingbot.testrail.io/index.php?/runs/view/4196
Client - https://hummingbot.testrail.io/index.php?/runs/view/4197

@rxlxrxsx rxlxrxsx linked an issue Mar 31, 2023 that may be closed by this pull request
Failed Test PR #11 - Cannot find module when running price and trade manual tests #12
Closed
@rxlxrxsx rxlxrxsx linked an issue Apr 3, 2023 that may be closed by this pull request
Failed Test PR #11 - Error after restarting amm_arb strategy #14
Closed
@mrhzysbl mrhzysbl removed a link to an issue Apr 4, 2023
Failed Test PR #11 - Unhandled error in background task #13
Closed
@mrhzysbl mrhzysbl linked an issue Apr 4, 2023 that may be closed by this pull request
Failed Test PR #11 - Unhandled error in background task #13
Closed
petioptrv
petioptrv suggested changes Apr 4, 2023
View reviewed changes
Copy link

@petioptrv petioptrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor cleanup suggestions, otherwise looks good

src/amm/amm.controllers.ts Outdated Show resolved Hide resolved
src/services/common-interfaces.ts Outdated Show resolved Hide resolved
vic-en and others added 2 commits April 4, 2023 08:53
petioptrv
petioptrv approved these changes Apr 5, 2023
View reviewed changes
Copy link

@petioptrv petioptrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

mrhzysbl
mrhzysbl approved these changes Apr 7, 2023
View reviewed changes
Copy link

@mrhzysbl mrhzysbl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed working by QA

  • Installed the dev branch without any issue
  • Connect gateway
  • Created AMM_ARB strategy using Zigzag connector
  • No errors shown when strategy is started
  • Bots are working as expected

@vic-en
Copy link

vic-en commented Apr 12, 2023

closing in favour of hummingbot#82

@vic-en vic-en closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrhzysbl mrhzysbl mrhzysbl approved these changes

@petioptrv petioptrv petioptrv approved these changes

Assignees

@vic-en vic-en

Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@james-hummingbot @geneuinely07 @rxlxrxsx @vic-en @petioptrv @mrhzysbl