Feat/dexalot #9
Closed
Feat/dexalot #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxlxrxsx
approved these changes
Mar 12, 2023
…h_update Batch order creation and cancelation for CLOB and injective
|
[ch-37162] |
|
This pull request has been linked to Shortcut Story #37162: Create Dexalot Connector in Gateway. |
…at/add-sushiswap-networks
(fix) don't decrement nonce
…/add-sushiswap-networks
CrimsonJacket
suggested changes
Mar 15, 2023
Comment on lines
20
to
32
| export const OrderType1 = { | ||
| MARKET: 0, | ||
| LIMIT: 1, | ||
| STOP: 2, // not used | ||
| STOPLIMIT: 3, // not used | ||
| }; | ||
|
|
||
| export const OrderType2 = { | ||
| GTC: 0, // Good Till Cancel, | ||
| FOK: 1, // Fill or Kill - requires immediate full fill or reverts | ||
| IOC: 2, // Immediate or Cancel - gets any fills & then canceled Remaining will not go in the orderbook | ||
| PO: 3, // Post Only - Requires to go in the orderbook without any fills or reverts | ||
| }; |
There was a problem hiding this comment.
Is there a better description for these 2 order types? i.e.
OrderType to determine between LIMIT, MARKET, etc
AdditionalOrderOptions to determine GTC, PO, etc
There was a problem hiding this comment.
done
I used TimeInForce instead of AdditionalOrderOptions
Comment on lines
42
to
63
| export const parseMarkerInfo = (marketInfo: MarketInfoStruct) => { | ||
| return { | ||
| baseSymbol: toUtf8(marketInfo.baseSymbol), | ||
| quoteSymbol: toUtf8(marketInfo.quoteSymbol), | ||
| buyBookId: toUtf8(marketInfo.buyBookId), | ||
| sellBookId: toUtf8(marketInfo.sellBookId), | ||
| minTradeAmount: marketInfo.minTradeAmount.toString(), | ||
| maxTradeAmount: marketInfo.maxTradeAmount.toString(), | ||
| auctionPrice: marketInfo.auctionPrice.toString(), | ||
| auctionMode: marketInfo.auctionMode, | ||
| makerRate: marketInfo.makerRate / 10000, // https://github.com/Dexalot/contracts/blob/1ec4b732b06dd2a25fe666cfde5b619af5b6f20b/contracts/TradePairs.sol#L43 | ||
| takerRate: marketInfo.takerRate / 10000, // https://github.com/Dexalot/contracts/blob/1ec4b732b06dd2a25fe666cfde5b619af5b6f20b/contracts/TradePairs.sol#L43 | ||
| baseDecimals: marketInfo.baseDecimals, | ||
| baseDisplayDecimals: marketInfo.baseDisplayDecimals, | ||
| quoteDecimals: marketInfo.quoteDecimals, | ||
| quoteDisplayDecimals: marketInfo.quoteDisplayDecimals, | ||
| allowedSlippagePercent: marketInfo.allowedSlippagePercent, | ||
| addOrderPaused: marketInfo.addOrderPaused, | ||
| pairPaused: marketInfo.pairPaused, | ||
| postOnly: marketInfo.postOnly, | ||
| }; | ||
| }; |
There was a problem hiding this comment.
I would classify this function and those defined below to be util functions and thus it should not be found in a constants file.
src/connectors/dexalot/dexalot.ts
Outdated
Comment on lines
64
to
68
| // this._exchangeContract = this.getContract('ExchangeSub', this._resources); | ||
| this._portfolioContract = this.getContract('PortfolioSub', this._resources); | ||
| // this._orderBooksContract = this.getContract('OrderBooks', this._resources); | ||
| this._tradePairsContract = this.getContract('TradePairs', this._resources); | ||
| // this._gasStationContract = this.getContract('GasStation', this._resources); |
There was a problem hiding this comment.
Please do remove these comments, I don't think they are being used or are useful for future reference
|
closing in favour of hummingbot#65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This is the main pr for Dexalot gateway. The functionality of this connector can be accessed through the endpoints on the club routes combined with the endpoints on the network routes.
Hence, the qa should test the following endpoints:
Notes for QA
The flow from creation to cancellation of orders is as follows:
[POST] /clob/ordersor/clob/batchOrderswith the createOrderParams. You will get a response similar to the one below[GET] /clob/ordersusing your public key address and the ClientOrderId returned in the response to create orders. By doing this, you'll be able to see the id (i.e. exchangeOrderId)