#475 About tab inside top toolbar. #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 23, 2019 11:50
wiiitek
reviewed
Apr 23, 2019
| @@ -74,6 +79,7 @@ protected void process(DBKey dbKey, HttpServletRequest req, HttpServletResponse | |||
| String suiteName = req.getParameter(Helper.SUITE_PARAM); | |||
| String suiteVersion = req.getParameter(Helper.VERSION_PARAM); | |||
| String formatted = req.getParameter(FORMATTED_PARAM); | |||
| resp.setHeader(APP_VERSION_HEADER, bundleVersionProvider.getBundleVersion()); | |||
There was a problem hiding this comment.
👍
Other metadata are send as JSON properties. Has anyone any ideas/thoughts about this being sent as header?
There was a problem hiding this comment.
I think it's fine because this is some kind of "meta" information. But maybe we should prefix the custom header name with X- (X-Application-Version), WDYT?
CC @Skejven
There was a problem hiding this comment.
X- prefix is a good idea. Sending it in the header is fine.
tkaik
approved these changes
Jul 3, 2019
tkaik
added
the
QA Required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Possibility to show simple "About" informations.
Motivation and Context
Mainly it allows users to check installed version of AET application.
Additionally it shows "Contact and Commercial Support" section and footer.
Issue: #475
Screenshots (if appropriate)
Toolbar element:
Popup:
Upgrade notes (if appropriate)
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.