Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/security vulnerabilities #470

Merged
merged 19 commits into from
Feb 15, 2019

Conversation

wblachowski
Copy link
Contributor

Fixes security vulnerabilities reported by GitHub.

Description

Closes #407

Motivation and Context

Reported vulnerabilities in AET 3.2.0:

vulnerabilities

Most of these come from bower, which is deprecated for over a year now so no chances of it getting patched. For this reason I ditched bower altogether replacing it with npm for downloading dependencies + gulp-npm-copy-deps for copying them to the assets directory,

Apart from bower, gulp-sass, browserify and commons-fileupload had to be updated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

@plutasnyy plutasnyy added the QA Required Requires manual tests, possible regression or impact on existing features. label Feb 1, 2019
@bambroziak
Copy link

bambroziak commented Feb 8, 2019

Tested and accepted:
Changes did not couse any error, AET build correctly and does not show any unexpected results.
Code were also covered and works fine.

QA Approve.

@tkaik tkaik merged commit 0013607 into wttech:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Required Requires manual tests, possible regression or impact on existing features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security vulnerabilities in report app dependencies
5 participants