Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print more meaningful error messages when suite.xml is malformed #459

Conversation

radoslawkarwacki
Copy link
Contributor

Print more meaningful error messages when suite.xml is malformed

Description

Provide as much data as possible when URLs are empty or duplicated

Motivation and Context

#436

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • I have reviewed (and updated if needed) the documentation regarding this change

I hereby agree to the terms of the AET Contributor License Agreement.

Provide as much data as possible when URLs are empty or duplicated
@plutasnyy
Copy link
Contributor

Please update changelog :)

@tkaik tkaik added the QA Required Requires manual tests, possible regression or impact on existing features. label Feb 15, 2019
@bambroziak
Copy link

Tested and rejected.

There is an issue there:
While I specify two tests on AET suite.xml and in both of them I've malformed (duplicated, left empty urls), I've got output only by first test, there is no any info about second test despite that it is also broken.

Other scenario is while I fix first test and leave second one broken, I've got output without information about that errors are located in test number 2. If first test is broken there is displaying info like that.

Expect of issues above error messages are working fine and displays useful data.

QA Covered.

@tkaik tkaik merged commit b131e4a into wttech:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Required Requires manual tests, possible regression or impact on existing features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants