Feature/source comparator passed test code compare #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernestosiak
requested review from
wiiitek,
tkaik,
wtomi,
malaskowski and
Jakub-Izbicki
|
@ernestosiak could you please resolve the conflict? |
|
I very like refactor that you did in Source Code Comparator 👍 Please resolve conflicting files |
wiiitek
suggested changes
Nov 7, 2018
core/jobs/src/main/java/com/cognifide/aet/job/common/comparators/source/CodeFormatter.java
Outdated
Show resolved
Hide resolved
...rc/test/java/com/cognifide/aet/job/common/comparators/source/SourceComparatorRegExpTest.java
Show resolved
Hide resolved
...rc/test/java/com/cognifide/aet/job/common/comparators/source/SourceComparatorRegExpTest.java
Outdated
Show resolved
Hide resolved
| @@ -53,7 +53,7 @@ public void setUp() { | |||
| } | |||
|
|
|||
| @Theory | |||
| public void removeEmptyLines(String[] dataPoint) throws Exception { | |||
| public void removeEmptyLines(String[] dataPoint) { | |||
| String input = dataPoint[0]; | |||
There was a problem hiding this comment.
Could We also add some tests for MARKUP, CONTENT and ALLFORMATTED types?
I wonder if we could have one input HTML file and three expected output files that shows the difference in code formatting..
...jobs/src/test/java/com/cognifide/aet/job/common/comparators/source/SourceComparatorTest.java
Show resolved
Hide resolved
core/jobs/src/main/java/com/cognifide/aet/job/common/comparators/source/SourceComparator.java
Outdated
Show resolved
Hide resolved
core/jobs/src/main/java/com/cognifide/aet/job/common/comparators/source/CodeFormatter.java
Show resolved
Hide resolved
core/jobs/src/main/java/com/cognifide/aet/job/common/comparators/source/Sources.java
Show resolved
Hide resolved
...jobs/src/test/java/com/cognifide/aet/job/common/comparators/source/SourceComparatorTest.java
Show resolved
Hide resolved
report/src/main/webapp/app/layout/main/url/reports/source.diff.html
Outdated
Show resolved
Hide resolved
Some additional unit tests for source formatter
Test update for removing empty lines code
malaskowski
added
QA Required
wiiitek
approved these changes
Nov 21, 2018
tkaik
suggested changes
Jan 23, 2019
|
tested, working well ✔️ |
tkaik
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful source comparator will save artifact with sources of pattern and tested data.
Description
Source comparator, even if successful, will save artifact with sources of pattern and tested data (no difference discovered). This way user can compare sources of them, just like in failed test.
Motivation and Context
Issue 369
Screenshots (if appropriate):
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.