Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizontal scrollbar - changed main.scss file #396

Merged
merged 5 commits into from
Oct 19, 2018

Conversation

ernestosiak
Copy link
Contributor

@ernestosiak ernestosiak commented Oct 16, 2018

Description

Fixed css file in order to get horizontal scrollbar on long pages.

Motivation and Context

On long js error messages there was no way to see whole message (there was no scrollbar)
Issue 393

Screenshots of the problem:

hotfix-scrollbar

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

Copy link
Contributor

@tkaik tkaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, please add Changelog entry in "Unreleased" section with this bugfix (include the issue link)

@ernestosiak
Copy link
Contributor Author

Changelog updated

@tkaik
Copy link
Contributor

tkaik commented Oct 16, 2018

@ernestosiak Please move the changelog entry to "Unreleased" section

@ernestosiak
Copy link
Contributor Author

changelog updated

@tkaik tkaik merged commit 8c9a71c into master Oct 19, 2018
@tkaik tkaik deleted the hotfix/horizontal-scrollbar-on-page branch October 19, 2018 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants