Feature/unable to save notes(comments) #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malaskowski
reviewed
Oct 2, 2018
| function notifyMetadataChanged() { | ||
| $rootScope.$emit('metadata:changed'); | ||
| } | ||
|
|
||
| function updateComment(vm, param) { | ||
| var caseName = vm.model.displayName.split(" ")[0]; |
There was a problem hiding this comment.
Is that logic applied anywhere else? If yes, maybe it would be worth to put it into one place and reuse.
|
This one fixes #87 |
malaskowski
added
the
QA Required
plutasnyy
reviewed
Nov 7, 2018
| function deleteNote(object) { | ||
| var text = object.comment; | ||
| delete object.comment; | ||
| if (object.comment) { | ||
| text = object.comment; |
6 tasks
|
@waldemarGr |
|
I tested it and for me everything works correctly 😀 |
|
Tested (x) |
tkaik
approved these changes
Feb 5, 2019
|
Please add Changelog entry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist:
I hereby agree to the terms of the AET Contributor License Agreement.