Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated annotations in cleaner #322

Merged
merged 2 commits into from
Aug 13, 2018
Merged

updated annotations in cleaner #322

merged 2 commits into from
Aug 13, 2018

Conversation

plutasnyy
Copy link
Contributor

I updated annotations in cleaner

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the AET Contributor License Agreement.

tkaik
tkaik suggested changes Aug 10, 2018
View reviewed changes
pom.xml
@@ -174,6 +174,24 @@
</dependency>

<!-- osgi -->
<dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like it's duplicated in lines 463-480 - please fix it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done f370712 ;)

@plutasnyy plutasnyy merged commit 60476ca into feature/upgrade-osgi-annotations Aug 13, 2018
@plutasnyy plutasnyy deleted the feature/upgrade-osgi-annotations-cleaner branch August 13, 2018 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkaik tkaik tkaik approved these changes

@malaskowski malaskowski malaskowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plutasnyy @tkaik @malaskowski