Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report popup window unification #367

Closed
radeklawgmin opened this issue Sep 25, 2018 · 1 comment · Fixed by #462
Closed

report popup window unification #367

radeklawgmin opened this issue Sep 25, 2018 · 1 comment · Fixed by #462
Assignees
Labels
enhancement good first issue This is great opportunity to start your adventure with AET. help wanted Hey, contributor! We need your help.

Comments

@radeklawgmin
Copy link
Contributor

radeklawgmin commented Sep 25, 2018

Version used

  • AET 3.0.

Context of the issue/feature

It looks like every single report pop-up window differs from one another a bit:

  • the history popup looks completely different from the shortcuts or note editor popup windows
  • the shortcuts "X" icon (to close the window) on the history window differs from the "X" icon on the history window while it is not available on the note-editor window.

For details see the image attached in the Appendix section.

Appendix

shortcuts

note-editor

aet-history

@mchrominski
Copy link

mchrominski commented Sep 25, 2018

I would also align the wording in the popup - the third line with "use" verb seems bit odd in the context of all the "press"es

Alternatively, if [] is used as dual option then it should be aligned to the last bullet with arrow left / arrow right

@malaskowski malaskowski added help wanted Hey, contributor! We need your help. good first issue This is great opportunity to start your adventure with AET. labels Sep 25, 2018
@wblachowski wblachowski self-assigned this Dec 27, 2018
@tkaik tkaik closed this as completed in #462 Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue This is great opportunity to start your adventure with AET. help wanted Hey, contributor! We need your help.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants