From 0282662781251e98c8cf76ab91502dd1279542cc Mon Sep 17 00:00:00 2001 From: Stefan Seeland <168659+stesee@users.noreply.github.com> Date: Sun, 22 Jan 2023 15:43:12 +0100 Subject: [PATCH 1/6] Added missing artefact - single file cli demo for windows --- .github/workflows/dotnet.yml | 2 ++ Codeuctivity.HtmlRenderer/Renderer.cs | 2 +- Codeuctivity.HtmlRendererTests/RendererTests.cs | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 2263b19..9fd1b9a 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -81,6 +81,7 @@ jobs: ./Codeuctivity.HtmlRenderer/bin/Release/*.nupkg ./Codeuctivity.HtmlRenderer/bin/Release/*.snupkg ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfilePortable/Codeuctivity.HtmlRendererCli.Portable.zip + ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfileWindows/Codeuctivity.HtmlRendererCli.exe deployTest: if: github.ref == 'refs/heads/main' @@ -125,3 +126,4 @@ jobs: ./Codeuctivity.HtmlRenderer/bin/Release/*.nupkg ./Codeuctivity.HtmlRenderer/bin/Release/*.snupkg ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfilePortable/Codeuctivity.HtmlRendererCli.Portable.zip + ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfileWindows/Codeuctivity.HtmlRendererCli.exe diff --git a/Codeuctivity.HtmlRenderer/Renderer.cs b/Codeuctivity.HtmlRenderer/Renderer.cs index 0c9f8c3..a5edef6 100644 --- a/Codeuctivity.HtmlRenderer/Renderer.cs +++ b/Codeuctivity.HtmlRenderer/Renderer.cs @@ -50,7 +50,7 @@ public Renderer(LaunchOptions? launchOptions = null) /// /// Browser fetcher - used to get chromium bins /// - public BrowserFetcher BrowserFetcher { get; private set; } + public BrowserFetcher? BrowserFetcher { get; private set; } private LaunchOptions LaunchOptions { get; } diff --git a/Codeuctivity.HtmlRendererTests/RendererTests.cs b/Codeuctivity.HtmlRendererTests/RendererTests.cs index 922dc6c..ac6540f 100644 --- a/Codeuctivity.HtmlRendererTests/RendererTests.cs +++ b/Codeuctivity.HtmlRendererTests/RendererTests.cs @@ -85,7 +85,7 @@ public async Task ShouldConvertHtmlToPdfWithOptions(string testFileName, bool pr } catch (InvocationException ex) { - // Working around issue in Jering.Javascript.NodeJS, silencing false positiv failing + // Working around issue in Jering.Javascript.NodeJS, silencing false positive failing Assert.True(RuntimeInformation.IsOSPlatform(OSPlatform.Windows), ex.Message); } } From f1c88464abc83f4c89a3f22b49296cb83609c9db Mon Sep 17 00:00:00 2001 From: Stefan Seeland <168659+stesee@users.noreply.github.com> Date: Sun, 22 Jan 2023 16:58:28 +0100 Subject: [PATCH 2/6] Update dotnet.yml --- .github/workflows/dotnet.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 9fd1b9a..2b4c5a4 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -30,6 +30,10 @@ jobs: run: dotnet restore - name: Build run: dotnet build --configuration Release --no-restore + - name: Publish FolderProfilePortable + run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfilePortable + - name: Publish FolderProfileWindows + run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfileWindows - name: Test run: dotnet test --no-build --verbosity normal --configuration Release - name: Publish Unit Test Results @@ -57,8 +61,10 @@ jobs: run: dotnet restore - name: Build run: dotnet build --configuration Release --no-restore - - name: Publish FolderProfileWindows + - name: Publish FolderProfilePortable run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfilePortable + - name: Publish FolderProfileWindows + run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfileWindows - name: Zip FolderProfilePortable uses: thedoctor0/zip-release@main with: @@ -103,6 +109,8 @@ jobs: run: dotnet build --configuration Release --no-restore - name: Publish FolderProfilePortable run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfilePortable + - name: Publish FolderProfileWindows + run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfileWindows - name: Zip FolderProfilePortable uses: thedoctor0/zip-release@main with: From 89466c0a01955970306c486134265621c13bb631 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 13 Feb 2023 16:02:24 +0000 Subject: [PATCH 3/6] Bump cla-assistant/github-action from 2.2.1 to 2.3.0 Bumps [cla-assistant/github-action](https://github.com/cla-assistant/github-action) from 2.2.1 to 2.3.0. - [Release notes](https://github.com/cla-assistant/github-action/releases) - [Commits](https://github.com/cla-assistant/github-action/compare/v2.2.1...v2.3.0) --- updated-dependencies: - dependency-name: cla-assistant/github-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- .github/workflows/cla.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cla.yml b/.github/workflows/cla.yml index 53e4f19..3c386ed 100644 --- a/.github/workflows/cla.yml +++ b/.github/workflows/cla.yml @@ -12,7 +12,7 @@ jobs: - name: "CLA Assistant" if: (github.event.comment.body == 'recheck' || github.event.comment.body == 'I have read the CLA Document and I hereby sign the CLA') || github.event_name == 'pull_request_target' # Beta Release - uses: cla-assistant/github-action@v2.2.1 + uses: cla-assistant/github-action@v2.3.0 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # the below token should have repo scope and must be manually added by you in the repository's secret From e0d8a518f5d0cd4c939d8d0d1ce9c337e3e7e5bd Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 27 Mar 2023 15:59:04 +0000 Subject: [PATCH 4/6] Bump actions/stale from 7 to 8 Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/stale/compare/v7...v8) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/stale.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 9d5c088..48d29bb 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -18,7 +18,7 @@ jobs: pull-requests: write steps: - - uses: actions/stale@v7 + - uses: actions/stale@v8 with: repo-token: ${{ secrets.GITHUB_TOKEN }} stale-issue-message: 'Stale issue message' From 5e704a7ff1b1c8d00e2f2c1a7376263635875ec2 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 10 Apr 2023 15:57:07 +0000 Subject: [PATCH 5/6] Bump PuppeteerSharp from 9.0.1 to 9.1.0 Bumps [PuppeteerSharp](https://github.com/hardkoded/puppeteer-sharp) from 9.0.1 to 9.1.0. - [Release notes](https://github.com/hardkoded/puppeteer-sharp/releases) - [Commits](https://github.com/hardkoded/puppeteer-sharp/compare/v9.0.1...v9.1.0) --- updated-dependencies: - dependency-name: PuppeteerSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj b/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj index cece021..2bc43f0 100644 --- a/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj +++ b/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj @@ -1,4 +1,4 @@ - + netstandard2.0;net7.0;net6.0 @@ -39,7 +39,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive From 78569f30005e0ad5da92c040fa5b1cc3f9f365f3 Mon Sep 17 00:00:00 2001 From: "Stefan.Seeland" <168659+stesee@users.noreply.github.com> Date: Wed, 12 Apr 2023 12:33:14 +0200 Subject: [PATCH 6/6] Bumped dev time dependencies --- Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj | 2 +- .../Codeuctivity.HtmlRendererCliTests.csproj | 4 ++-- .../Codeuctivity.HtmlRendererTests.csproj | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj b/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj index 2bc43f0..bb254d7 100644 --- a/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj +++ b/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj @@ -40,7 +40,7 @@ - + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/Codeuctivity.HtmlRendererCliTests/Codeuctivity.HtmlRendererCliTests.csproj b/Codeuctivity.HtmlRendererCliTests/Codeuctivity.HtmlRendererCliTests.csproj index 40890bd..7b34c5a 100644 --- a/Codeuctivity.HtmlRendererCliTests/Codeuctivity.HtmlRendererCliTests.csproj +++ b/Codeuctivity.HtmlRendererCliTests/Codeuctivity.HtmlRendererCliTests.csproj @@ -7,8 +7,8 @@ - - + + runtime; build; native; contentfiles; analyzers; buildtransitive all diff --git a/Codeuctivity.HtmlRendererTests/Codeuctivity.HtmlRendererTests.csproj b/Codeuctivity.HtmlRendererTests/Codeuctivity.HtmlRendererTests.csproj index 92c30c9..e8f2288 100644 --- a/Codeuctivity.HtmlRendererTests/Codeuctivity.HtmlRendererTests.csproj +++ b/Codeuctivity.HtmlRendererTests/Codeuctivity.HtmlRendererTests.csproj @@ -16,13 +16,13 @@ - + - + runtime; build; native; contentfiles; analyzers; buildtransitive all - + runtime; build; native; contentfiles; analyzers; buildtransitive