diff --git a/.github/workflows/cla.yml b/.github/workflows/cla.yml index 53e4f19..3c386ed 100644 --- a/.github/workflows/cla.yml +++ b/.github/workflows/cla.yml @@ -12,7 +12,7 @@ jobs: - name: "CLA Assistant" if: (github.event.comment.body == 'recheck' || github.event.comment.body == 'I have read the CLA Document and I hereby sign the CLA') || github.event_name == 'pull_request_target' # Beta Release - uses: cla-assistant/github-action@v2.2.1 + uses: cla-assistant/github-action@v2.3.0 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # the below token should have repo scope and must be manually added by you in the repository's secret diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 2263b19..2b4c5a4 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -30,6 +30,10 @@ jobs: run: dotnet restore - name: Build run: dotnet build --configuration Release --no-restore + - name: Publish FolderProfilePortable + run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfilePortable + - name: Publish FolderProfileWindows + run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfileWindows - name: Test run: dotnet test --no-build --verbosity normal --configuration Release - name: Publish Unit Test Results @@ -57,8 +61,10 @@ jobs: run: dotnet restore - name: Build run: dotnet build --configuration Release --no-restore - - name: Publish FolderProfileWindows + - name: Publish FolderProfilePortable run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfilePortable + - name: Publish FolderProfileWindows + run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfileWindows - name: Zip FolderProfilePortable uses: thedoctor0/zip-release@main with: @@ -81,6 +87,7 @@ jobs: ./Codeuctivity.HtmlRenderer/bin/Release/*.nupkg ./Codeuctivity.HtmlRenderer/bin/Release/*.snupkg ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfilePortable/Codeuctivity.HtmlRendererCli.Portable.zip + ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfileWindows/Codeuctivity.HtmlRendererCli.exe deployTest: if: github.ref == 'refs/heads/main' @@ -102,6 +109,8 @@ jobs: run: dotnet build --configuration Release --no-restore - name: Publish FolderProfilePortable run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfilePortable + - name: Publish FolderProfileWindows + run: dotnet publish ./Codeuctivity.HtmlRendererCli --configuration Release -f net6.0 -p:PublishProfile=FolderProfileWindows - name: Zip FolderProfilePortable uses: thedoctor0/zip-release@main with: @@ -125,3 +134,4 @@ jobs: ./Codeuctivity.HtmlRenderer/bin/Release/*.nupkg ./Codeuctivity.HtmlRenderer/bin/Release/*.snupkg ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfilePortable/Codeuctivity.HtmlRendererCli.Portable.zip + ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfileWindows/Codeuctivity.HtmlRendererCli.exe diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 9d5c088..48d29bb 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -18,7 +18,7 @@ jobs: pull-requests: write steps: - - uses: actions/stale@v7 + - uses: actions/stale@v8 with: repo-token: ${{ secrets.GITHUB_TOKEN }} stale-issue-message: 'Stale issue message' diff --git a/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj b/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj index cece021..bb254d7 100644 --- a/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj +++ b/Codeuctivity.HtmlRenderer/Codeuctivity.HtmlRenderer.csproj @@ -1,4 +1,4 @@ - + netstandard2.0;net7.0;net6.0 @@ -39,8 +39,8 @@ - - + + all runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/Codeuctivity.HtmlRenderer/Renderer.cs b/Codeuctivity.HtmlRenderer/Renderer.cs index 0c9f8c3..a5edef6 100644 --- a/Codeuctivity.HtmlRenderer/Renderer.cs +++ b/Codeuctivity.HtmlRenderer/Renderer.cs @@ -50,7 +50,7 @@ public Renderer(LaunchOptions? launchOptions = null) /// /// Browser fetcher - used to get chromium bins /// - public BrowserFetcher BrowserFetcher { get; private set; } + public BrowserFetcher? BrowserFetcher { get; private set; } private LaunchOptions LaunchOptions { get; } diff --git a/Codeuctivity.HtmlRendererCliTests/Codeuctivity.HtmlRendererCliTests.csproj b/Codeuctivity.HtmlRendererCliTests/Codeuctivity.HtmlRendererCliTests.csproj index 40890bd..7b34c5a 100644 --- a/Codeuctivity.HtmlRendererCliTests/Codeuctivity.HtmlRendererCliTests.csproj +++ b/Codeuctivity.HtmlRendererCliTests/Codeuctivity.HtmlRendererCliTests.csproj @@ -7,8 +7,8 @@ - - + + runtime; build; native; contentfiles; analyzers; buildtransitive all diff --git a/Codeuctivity.HtmlRendererTests/Codeuctivity.HtmlRendererTests.csproj b/Codeuctivity.HtmlRendererTests/Codeuctivity.HtmlRendererTests.csproj index 92c30c9..e8f2288 100644 --- a/Codeuctivity.HtmlRendererTests/Codeuctivity.HtmlRendererTests.csproj +++ b/Codeuctivity.HtmlRendererTests/Codeuctivity.HtmlRendererTests.csproj @@ -16,13 +16,13 @@ - + - + runtime; build; native; contentfiles; analyzers; buildtransitive all - + runtime; build; native; contentfiles; analyzers; buildtransitive diff --git a/Codeuctivity.HtmlRendererTests/RendererTests.cs b/Codeuctivity.HtmlRendererTests/RendererTests.cs index 922dc6c..ac6540f 100644 --- a/Codeuctivity.HtmlRendererTests/RendererTests.cs +++ b/Codeuctivity.HtmlRendererTests/RendererTests.cs @@ -85,7 +85,7 @@ public async Task ShouldConvertHtmlToPdfWithOptions(string testFileName, bool pr } catch (InvocationException ex) { - // Working around issue in Jering.Javascript.NodeJS, silencing false positiv failing + // Working around issue in Jering.Javascript.NodeJS, silencing false positive failing Assert.True(RuntimeInformation.IsOSPlatform(OSPlatform.Windows), ex.Message); } }