diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml index 2263b19..9fd1b9a 100644 --- a/.github/workflows/dotnet.yml +++ b/.github/workflows/dotnet.yml @@ -81,6 +81,7 @@ jobs: ./Codeuctivity.HtmlRenderer/bin/Release/*.nupkg ./Codeuctivity.HtmlRenderer/bin/Release/*.snupkg ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfilePortable/Codeuctivity.HtmlRendererCli.Portable.zip + ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfileWindows/Codeuctivity.HtmlRendererCli.exe deployTest: if: github.ref == 'refs/heads/main' @@ -125,3 +126,4 @@ jobs: ./Codeuctivity.HtmlRenderer/bin/Release/*.nupkg ./Codeuctivity.HtmlRenderer/bin/Release/*.snupkg ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfilePortable/Codeuctivity.HtmlRendererCli.Portable.zip + ./Codeuctivity.HtmlRendererCli/bin/Release/net6.0/publish/FolderProfileWindows/Codeuctivity.HtmlRendererCli.exe diff --git a/Codeuctivity.HtmlRenderer/Renderer.cs b/Codeuctivity.HtmlRenderer/Renderer.cs index 0c9f8c3..a5edef6 100644 --- a/Codeuctivity.HtmlRenderer/Renderer.cs +++ b/Codeuctivity.HtmlRenderer/Renderer.cs @@ -50,7 +50,7 @@ public Renderer(LaunchOptions? launchOptions = null) /// /// Browser fetcher - used to get chromium bins /// - public BrowserFetcher BrowserFetcher { get; private set; } + public BrowserFetcher? BrowserFetcher { get; private set; } private LaunchOptions LaunchOptions { get; } diff --git a/Codeuctivity.HtmlRendererTests/RendererTests.cs b/Codeuctivity.HtmlRendererTests/RendererTests.cs index 922dc6c..ac6540f 100644 --- a/Codeuctivity.HtmlRendererTests/RendererTests.cs +++ b/Codeuctivity.HtmlRendererTests/RendererTests.cs @@ -85,7 +85,7 @@ public async Task ShouldConvertHtmlToPdfWithOptions(string testFileName, bool pr } catch (InvocationException ex) { - // Working around issue in Jering.Javascript.NodeJS, silencing false positiv failing + // Working around issue in Jering.Javascript.NodeJS, silencing false positive failing Assert.True(RuntimeInformation.IsOSPlatform(OSPlatform.Windows), ex.Message); } }