Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the plugin breaks blocks #39

Closed
stefan-cotitosu opened this issue Jan 31, 2019 · 19 comments
Closed

Updating the plugin breaks blocks #39

stefan-cotitosu opened this issue Jan 31, 2019 · 19 comments

Comments

@stefan-cotitosu
Copy link

After updating the plugin to version 1.1.3 some blocks contain invalid content.
This is happening if you try to import the block. I didn't have it on a page, to test if the blocks keep working properly after updating the plugin.

neve-footer-error

I've tried both option Resolve and Convert to HTML but none of them make the block as it was before. The template.json file of the block was edited before adding it in the theme, all occurrences of "id": "wp-block-themeisle-blocks-..." were removed.
I tried to navigate to manage reusable blocks page, and upload the template.json file, it gave me an error, that the file contains invalid content.

From what I see, there is no way to bring the block back from the json file, just rebuild it from scratch. Unfortunately, I don't have more details like the kind of blocks that were used in it, I can't see the initial structure anymore.

A similar situation was happening before when changes were applied to the Section block. All margins were reseted for the already created blocks after updating the plugin.

@rodica-andronache
Copy link

@HardeepAsrani when you have time, if you can share your feedback here it would be great 👍

@HardeepAsrani
Copy link
Member

Thanks. Which blocks are breaking? Which block is it in your screenshot?

@HardeepAsrani
Copy link
Member

You can click on resolve to see the code which will have the className that you can use to tell me the name of the block.

@HardeepAsrani
Copy link
Member

Or you can also attach the JSON of this template.

@stefan-cotitosu
Copy link
Author

Here is the HTML code after I clicked Convert to HTML

<div class="wp-block-themeisle-blocks-advanced-column" id="wp-block-themeisle-blocks-advanced-column-24946ab0" style="border-top-width:0px;border-right-width:0px;border-bottom-width:0px;border-left-width:0px;border-style:solid;border-radius:0px">
</div>

The broken section within the screenshot is Neve Footer.
broken-section-ss

Below is the json file.
https://github.com/stefan-cotitosu/neve/blob/development/gutenberg/blocks/footer/template.json

Thank you for looking into this 👍

@radu-themeisle
Copy link

I also experienced some issues with the FA icons block, but I managed to fix it by clicking "Resolve". Seems I was lucky...

@stefan-cotitosu
Copy link
Author

I did a few test and below are the results.

  • Neve footer section is not working with any version of the plugin, I’ve tested it with 1.1.3, 1.1.2, 1.1.1, 1.1.0, here I will make the section again, as I suspect the json file to be broken, even tho it was working properly when I made it
  • updating from version 1.1.0 -> 1.1.3 breaks both Advanced Heading and Font Awesome Icons blocks
  • version 1.1.1 and 1.1.2, if you add an Font Awesome Icons block, publish it, everything it’s fine in editor-preview and on front-end, if you refresh the editor-preview page, the block becomes invalid
  • updating from versions 1.1.1 or 1.1.2 to 1.1.3 seem to fix Font Awesome Icons and Advanced Heading blocks.

Besides the Neve Footer section, everything works fine for me in version 1.1.3 of the plugin.

I don't understand why these blocks are working fine in the latest version of the plugin and don't work anymore in the previous versions. I would expect things to work in the older versions of the product.

I used the plugin from wordpress.org in all tests mentioned above.

@rodica-andronache
Copy link

@stefan-cotitosu @HardeepAsrani from what I've tested I've seen this pattern:

  1. when 'WooCommerce' and 'WooCommerce Blocks' are installed, none of the Otter blocks are accessible anymore https://prnt.sc/meqwjo
  2. when 'Visualizer Lite' is installed, I got this error for most of the blocks https://prnt.sc/meqs0s

@HardeepAsrani
Copy link
Member

  1. Yes, the first one was reported yesterday. Weird thing is that it’s inconsistent. It works for me locally but not on poopy. Same happens with the guy who reported it.

  2. Will look into this, thanks. 😀

@HardeepAsrani
Copy link
Member

For the second one, can you confirm it’s working without Visualizer?

@rodica-andronache
Copy link

yes, it's working without visualizer :) Thanks

@HardeepAsrani
Copy link
Member

@radu-themeisle @stefan-cotitosu Can you check with Font Awesome Block issue? It should be fixed now.

@rodica-andronache For your two issues:

  1. WooCommerce issue should be fixed. Now Otter should load, and WooCommerce Blocks shouldn't. 😄 It appears to be an issue on their side, I believe.

  2. Can you check if Visualizer issue still happens? I wasn't able to reproduce it on my side.

@stefan-cotitosu
Copy link
Author

@HardeepAsrani For me Font Awesome Block is working well in the latest version of the plugin.

It's not working in version 1.1.2 but I am not sure how relevant is this, as the idea is to have the latest version of the product. The only issue here would be if someone have an older version of Otter and the latest version of Neve which has the blocks in it.

@rodica-andronache
Copy link

@HardeepAsrani the issue with WooCommerce Blocks is fixed for me too, but I still have the problem with Visualizer. Let me know if there is something I can do for this 👍

@HardeepAsrani
Copy link
Member

@rodica-andronache I've no idea what's causing them. I mean that particular block has nothing to do with any external library at all.

@rodica-andronache
Copy link

@HardeepAsrani if you can't replicate it, you can check it here. It's only happening for the sections that have font awesome block from what I've seen
http://friendly-cheetah.w5.poopy.life/
user: hardeep
pass: bn8jDTs@PKwCSp&NwU6bE64V

@HardeepAsrani
Copy link
Member

@rodica-andronache I'm also able to reproduce on poopy.life but not locally. 😞 I can't really debug if can't reproduce locally.

@rodica-andronache
Copy link

@HardeepAsrani will you push an update for visualizer, with what you managed to do? :)

@HardeepAsrani
Copy link
Member

Not yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants