-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the plugin breaks blocks #39
Comments
@HardeepAsrani when you have time, if you can share your feedback here it would be great 👍 |
Thanks. Which blocks are breaking? Which block is it in your screenshot? |
You can click on resolve to see the code which will have the className that you can use to tell me the name of the block. |
Or you can also attach the JSON of this template. |
Here is the HTML code after I clicked
The broken section within the screenshot is Neve Footer. Below is the json file. Thank you for looking into this 👍 |
I also experienced some issues with the FA icons block, but I managed to fix it by clicking "Resolve". Seems I was lucky... |
I did a few test and below are the results.
Besides the Neve Footer section, everything works fine for me in version 1.1.3 of the plugin. I don't understand why these blocks are working fine in the latest version of the plugin and don't work anymore in the previous versions. I would expect things to work in the older versions of the product. I used the plugin from wordpress.org in all tests mentioned above. |
@stefan-cotitosu @HardeepAsrani from what I've tested I've seen this pattern:
|
|
For the second one, can you confirm it’s working without Visualizer? |
yes, it's working without visualizer :) Thanks |
@radu-themeisle @stefan-cotitosu Can you check with Font Awesome Block issue? It should be fixed now. @rodica-andronache For your two issues:
|
@HardeepAsrani For me Font Awesome Block is working well in the latest version of the plugin. It's not working in version 1.1.2 but I am not sure how relevant is this, as the idea is to have the latest version of the product. The only issue here would be if someone have an older version of Otter and the latest version of Neve which has the blocks in it. |
@HardeepAsrani the issue with WooCommerce Blocks is fixed for me too, but I still have the problem with Visualizer. Let me know if there is something I can do for this 👍 |
@rodica-andronache I've no idea what's causing them. I mean that particular block has nothing to do with any external library at all. |
@HardeepAsrani if you can't replicate it, you can check it here. It's only happening for the sections that have font awesome block from what I've seen |
@rodica-andronache I'm also able to reproduce on poopy.life but not locally. 😞 I can't really debug if can't reproduce locally. |
@HardeepAsrani will you push an update for visualizer, with what you managed to do? :) |
Not yet. |
After updating the plugin to version 1.1.3 some blocks contain invalid content.
This is happening if you try to import the block. I didn't have it on a page, to test if the blocks keep working properly after updating the plugin.
I've tried both option
Resolve
andConvert to HTML
but none of them make the block as it was before. The template.json file of the block was edited before adding it in the theme, all occurrences of"id": "wp-block-themeisle-blocks-..."
were removed.I tried to navigate to manage reusable blocks page, and upload the template.json file, it gave me an error, that the file contains invalid content.
From what I see, there is no way to bring the block back from the json file, just rebuild it from scratch. Unfortunately, I don't have more details like the kind of blocks that were used in it, I can't see the initial structure anymore.
A similar situation was happening before when changes were applied to the Section block. All margins were reseted for the already created blocks after updating the plugin.
The text was updated successfully, but these errors were encountered: