Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: string translation #2401

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

fix: string translation #2401

wants to merge 2 commits into from

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 7, 2024 •
edited
Loading

Closes https://github.com/Codeinwp/otter-internals/issues/232

Summary

Fixed the issues related to translation and some errors reported by Eslint.

Note

I found that the eEslint config file was not working with wp presets. Thus, after fixing it, there are some extra fixes in this PR based on WordPress rules. Some were marked as warnings since they are not a priority for now.

The generate .pot file with ALL STRINGS: https://pastebin.com/cKzTCthH

Archive with all strings and separated one with only pro strings: Archive.zip (generated with wp i18n make-pot . languages/otter-all-strings.pot and wp i18n make-pot . languages/otter-pro-strings.pot --include=src/pro,otter-pro )

Testing

Check if all the necessary strings are in the pot file.

Checklist before the final review

  • Included E2E or unit tests for the changes in this PR.
  • Visual elements are not affected by independent changes.
  • It is at least compatible with the minimum WordPress version.
  • It loads additional script in frontend only if it is required.
  • Does not impact the Core Web Vitals.
  • In case of deprecation, old blocks are safely migrated.
  • It is usable in Widgets and FSE.
  • Copy/Paste is working if the attributes are modified.
  • PR is following the best practices

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 7, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Oct 7, 2024 that may be closed by this pull request
Prepare the plugin for localization #2375
Open
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 9, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review October 9, 2024 12:24
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 9, 2024
@pirate-bot
Copy link
Contributor

Bundle Size Diff

Package Old Size New Size Diff
Animations 271.38 KB 271.41 KB 27 B (0.01%)
Blocks 1.56 MB 1.56 MB 50 B (0.00%)
CSS 100.87 KB 100.89 KB 20 B (0.02%)
Dashboard 198.32 KB 198.47 KB 155 B (0.08%)
Onboarding 161.11 KB 161.1 KB -14 B (-0.01%)
Export Import 97.78 KB 97.78 KB 0 B (0.00%)
Pro 422.93 KB 423.16 KB 236 B (0.05%)

@pirate-bot
Copy link
Contributor

pirate-bot commented Oct 9, 2024 •
edited
Loading

Plugin build for 25fddec is ready 🛎️!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare the plugin for localization
2 participants
@Soare-Robert-Daniel @pirate-bot