Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review block generating double schema markup #2230

Open
milicavs opened this issue Jun 3, 2024 · 4 comments
Open

Review block generating double schema markup #2230

milicavs opened this issue Jun 3, 2024 · 4 comments
Labels
bug This label could be used to identify issues that are caused by a defect in the product.

Comments

@milicavs
Copy link

milicavs commented Jun 3, 2024

Description

The review block is generating the Product schema markup two times.

Step-by-step reproduction instructions

  1. Go to https://validator.schema.org/
  2. Enter any URL from the Themeisle blog that has the review block added (eg. https://themeisle.com/blog/wp-engine-review-for-wordpress/)
  3. See how the Product item is detected twice

OR

  1. Go to any URL from the Themeisle blog that has the review block added (e.g. https://themeisle.com/blog/wp-engine-review-for-wordpress/).
  2. View the source of the page and look for the Product markup.
  3. You'll see two script tags with the markup one right after the other.

Screenshots, screen recording, code snippet or Help Scout ticket

https://monosnap.com/file/W7ollK5t4wRhW5WIk1EgVJvYeOSp2d

Environment info

https://pastebin.com/yvZ1Q9yQ

Is the issue you are reporting a regression

No

@milicavs milicavs added the bug This label could be used to identify issues that are caused by a defect in the product. label Jun 3, 2024
@vytisbulkevicius
Copy link
Contributor

I can't replicate this issue on a fresh website with Otter ratings and schema enabled. @Soare-Robert-Daniel, do you think it's an issue coming from Otter or some misconfiguration on themeisle.com blog? [I have limited admin rights on that website]

@Soare-Robert-Daniel
Copy link
Contributor

@vytisbulkevicius, I'm not sure. Most of the issues reported on it involve missing schema, but I could not replicate the behaviour.

For the duplicates I think we can put some guards even if we can not reproduce it.

@ineagu
Copy link
Contributor

ineagu commented Jul 9, 2024

@milicavs might be wp rocket here who is messing critical css? if this works well on a fresh instance?

@milicavs
Copy link
Author

milicavs commented Jul 9, 2024

@ineagu Same issue appears when WP Rocket is disabled. Here's an example review from the test site where we don't have it: https://dmvatcfmnr.wpdns.site/rocket-net-review/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product.
Projects
None yet
Development

No branches or pull requests

4 participants