Add missing role=button and tabindex=0 for search icon button to fix AMP validity #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMP requires these attributes for elements that have an `on="tap:..."` attribute, unless they are buttons or links (i.e. elements that aren't normally tappable/tabbable).
westonruter
changed the title
|
Thanks a lot for your contribution, @westonruter! |
|
🎉 This PR is included in version 2.6.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AMP requires
roleandtabindexattributes for elements that have anon="tap:..."attribute, unless they are buttons or links (i.e. elements that aren't normally tappable/tabbable).Originally reported on the AMP plugin support forum: https://wordpress.org/support/topic/the-attribute-tabindex-in-tag-span-is-missing-or-incorrect/
Note the changes where should be done automatically by the AMP plugin in the future (via ampproject/amp-wp#4528) but it is best if the changes are done up-front.
As an alternative to adding these attributes, the icon could instead be represented by a
buttoninstead of aspan.Will affect visual aspect of the product
YES (when tabbing there may be an outline on the element)
Test instructions