Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Can't create a New File #1146

Closed
avnerbarr opened this issue Mar 12, 2023 · 6 comments · Fixed by #1365
Closed

🐞 Can't create a New File #1146

avnerbarr opened this issue Mar 12, 2023 · 6 comments · Fixed by #1365
Assignees
Labels
bug Something isn't working

Comments

@avnerbarr
Copy link

Description

In an existing project, right click in the project explorer

image

click file.

Nothing appears

Go to directory on disk , do ls

you will see some blank files (untitled)

image

To Reproduce

create a new project in tmp

I did yarn init

open the project in codeedit

right click an existing file and click "new file"

Expected Behavior

should open a dialogue to create a file and the appropriate extension. the file should appear in the project explorer

Version Information

0.0.3 alpha (30)

ventura 13.2.1

Additional Context

No response

Screenshots

No response

@avnerbarr avnerbarr added the bug Something isn't working label Mar 12, 2023
@lukepistrol
Copy link
Member

This is certainly a regression introduced recently and most likely also linked to the following issue since the files are actually created but the project navigator isn't updating:

@avnerbarr thank you for the detailed report.

@lukepistrol lukepistrol changed the title can't create a file 🐞 Can't create a New File Mar 23, 2023
@lukepistrol lukepistrol moved this from 🆕 New to 📋 Todo in CodeEdit Project Mar 23, 2023
@armartinez
Copy link
Contributor

@lukepistrol are you looking into this ? I'm trying to work up a fix, I did get to the not updating part so this line is not working correctly on the OutlineMenu class :
200 outlineView.expandItem((item?.isFolder ?? true) ? item : item?.parent)

@lukepistrol
Copy link
Member

@armartinez not really for now - just triaging some newer issues. If you want to take on this issue just let me know and I'll assign you 😊 (Also leave a comment on the other linked issue so I can assign you there too)

@armartinez
Copy link
Contributor

@lukepistrol yes I'll take the issue, it seems like a nice one to start contributing to the project

@lukepistrol
Copy link
Member

Perfect!

@armartinez
Copy link
Contributor

@lukepistrol #1236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🏁 Complete
3 participants