Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Margin, colours and saving issue on json files #1065

Closed
JGeek00 opened this issue Feb 19, 2023 · 3 comments
Closed

🐞 Margin, colours and saving issue on json files #1065

JGeek00 opened this issue Feb 19, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@JGeek00
Copy link

JGeek00 commented Feb 19, 2023

Description

Seems that the editor is not working fine with json files (see attached video).

I have that json file that I created on VSCode some time ago and when editing it I saw some issues.

  • When I edit it with CodeEdit, the first new line that I add with CodeEdit has a bigger margin to the previous line.
  • The new lines are not being coloured.
  • When I try to save the changes, the file is not being saved.
json-error.mp4

To Reproduce

See the attached video.

Expected behavior

  • The margin should always be the same.
  • The new code that I add should be coloured.
  • When I click on Save, the changes should be saved.

Version information

CodeEdit: 0.0.2 (26)
macOS: 13.2.1
Xcode: don't know (is it relevant?)

Additional context

No response

@JGeek00 JGeek00 added the bug Something isn't working label Feb 19, 2023
@austincondiff austincondiff moved this from 🆕 New to 📋 Todo in CodeEdit Project Feb 23, 2023
@thecoolwinter
Copy link
Collaborator

This looks like it's related to a combination of CodeEditApp/CodeEditTextView#142 and CodeEditApp/CodeEditTextView#160. 142 should have fixed the editing highlight issues, and 160 the saving one. Could you test this again on the latest alpha and see if it's still an issue after those changes?

@JGeek00
Copy link
Author

JGeek00 commented Apr 8, 2023

Yes, that seems to be fixed. However, I found this new issue https://github.com/CodeEditApp/CodeEditTextView/issues/175.

@thecoolwinter
Copy link
Collaborator

Okay, I'm going to close this then in favor of CodeEditApp/CodeEditTextView#175

@github-project-automation github-project-automation bot moved this from 📋 Todo to 🏁 Complete in CodeEdit Project Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🏁 Complete
Development

No branches or pull requests

2 participants