Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Returning a message to docker client after powerstrip fails #79

Open
aanm opened this issue Apr 12, 2015 · 2 comments
Open

Proposal: Returning a message to docker client after powerstrip fails #79

aanm opened this issue Apr 12, 2015 · 2 comments

Comments

@aanm
Copy link
Contributor

aanm commented Apr 12, 2015

Powerstrips should return a message to the docker client that made the request informing the request couldn't be completed if one of the adapters fail.
I propose that message to be showed would be a string from the adapter that would be present in ModifiedClientRequest.Body

@binocarlos
Copy link
Contributor

Agreed - a message and a 5xx status code should end up at the docker client. I think we should send the message back in the same format that the normal docker server sends its errors.

ModifiedClientRequest.Body is for normal operations - I think if there is an error, a 500 status and a string that is however the docker server formats its errors - JSON or plaintext?

@aanm
Copy link
Contributor Author

aanm commented Apr 13, 2015

IMHO since the error is returned in a HTTP form, the error message it should be plainttext

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants