Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDS CompressedBiomeDefinitionListSerializer_v582 deserialize/serialize error #261

Open
romanalexander opened this issue Sep 16, 2024 · 4 comments

Comments

@romanalexander
Copy link
Contributor

Somewhere around protocol 729 the CompressedBiomeDefinitionList packet got changed(?) and won't byte-for-byte serialize correctly, causing vanilla BDS to disconnect. Observed on client v1.21.30

Reproduce:
On latest head try to connect through BDS via ProxyPass with packet reserializing
Client will disconnect with Broken Packet unless you bypass deserializer for CompressedBiomeDefinitionList

@Kaooot
Copy link
Contributor

Kaooot commented Sep 16, 2024

I'm not aware of any changes to CompressedBiomeDefinitionListPacket in v729 and it worked fine for me when I used the latest ProxyPass version with changed codec for v729.

@romanalexander
Copy link
Contributor Author

I just retested on b315ef6 this still occurs. On BDS 1.21.30.25, client version 1.21.30

Flat world won't send any compressed biome data, only a vanilla singleplayer world will.

@Alemiz112
Copy link
Member

I was able to repro this. Will investigate soon.

@romanalexander
Copy link
Contributor Author

attached is the state of the bytebuffer bidirectionally packetlog.zip
the serialized data is much larger than what BDS sends

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants