Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xpath_query.sl should have ability to override security options #924

Open
ferrisb opened this issue Jan 30, 2017 · 4 comments
Open

xpath_query.sl should have ability to override security options #924

ferrisb opened this issue Jan 30, 2017 · 4 comments
Assignees

Comments

@ferrisb
Copy link

ferrisb commented Jan 30, 2017

I currently have an issue with the ability to perform an XPATH query (xpath_query.sl) due to the security limitations with "http://apache.org/xml/features/disallow-doctype-decl" set to true.

As a workaround I convert it to JSON and override using the parsing feature.

              - parsing_features: |
                      http://apache.org/xml/features/disallow-doctype-decl false

Can the parsing feature be added to the xpath_query.sl and allow the developer to override the security if needed?

@tethryus
Copy link
Contributor

Hello @ferrisb, have you tried running the operation with secure_processing: false?

@ferrisb
Copy link
Author

ferrisb commented Jan 31, 2017

Yes - I tried that, I received the same message about "http://apache.org/xml/features/disallow-doctype-decl" being set to true.

@tethryus
Copy link
Contributor

tethryus commented Feb 2, 2017

Will look into it and provide a fix as soon as possible. Thanks for catching that up.

@tethryus
Copy link
Contributor

tethryus commented Feb 3, 2017

Hello @ferrisb, I have found the fix needed in order to make the operation work. I will commit the changes and I will let you know as soon as it will be available on the content repository.

Edit: I have a follow up question. Are you getting the xml from a file or a string? I would like to make sure that the fix will work for the use case that you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants