Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added logPlayerConnections into config of bridge module #22

Merged
merged 2 commits into from
Jun 4, 2019
Merged

added logPlayerConnections into config of bridge module #22

merged 2 commits into from
Jun 4, 2019

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Jun 4, 2019

No description provided.

@codeclimate
Copy link

codeclimate bot commented Jun 4, 2019

Analysis results are not available for those commits

View more on Code Climate.

juliarn
juliarn suggested changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@juliarn juliarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also add a check, whether the boolean exists. You could just default the boolean to true in the config object.

...odules/cloudnet-bridge/src/main/java/de/dytanic/cloudnet/ext/bridge/BridgeConfiguration.java Outdated Show resolved Hide resolved
...main/java/de/dytanic/cloudnet/ext/bridge/node/listener/NodeCustomChannelMessageListener.java Outdated Show resolved Hide resolved
...main/java/de/dytanic/cloudnet/ext/bridge/node/listener/NodeCustomChannelMessageListener.java Outdated Show resolved Hide resolved
@juliarn juliarn changed the base branch from master to development June 4, 2019 20:57
@juliarn juliarn merged commit 8a9d3e8 into CloudNetService:development Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliarn juliarn juliarn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Meldiron @juliarn