-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KataPotter Kata #1
Comments
@JoseLlorensRipolles when is your solution? |
Wow I've forgot! As soon as I can! Have you worked it out yet ? @tonilopezmr |
Hey @tonilopezmr I've just finished it. You can take a look at my fork (https://github.com/JoseLlorensRipolles/Katas/blob/master-java/KataPotter/src/main/java/katapotter/KataPotter.java). What do you think about it ? I'll continue refractoring it when I have some time! |
Your code it's very ugly, it's not object oriented but if you are happy with your code. I'm going to implement the sets and we can compare, anyway with your test you can refactor easily 👍 But what happens with your code non object oriented? If you have a bit change with your data you need also change the test, in object oriented that does not occurs, because your bussines logic is encapsulated in objects. |
I'm not sure on how to use the OO paradigm here. We can discuss it in slack. Eitherway I'll improve my code as soos as I can @tonilopezmr |
It's not difficult, a book is a Book, a collection of books is a BookBasket with price, etc, etc... Transform your thought to code. |
@JoseLlorensRipolles Hey have a PR!! to add the KataPotter !! |
Create a package katapotter and do it.
The text was updated successfully, but these errors were encountered: