Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KataPotter Kata #1

Open
tonilopezmr opened this issue Apr 8, 2016 · 7 comments
Open

KataPotter Kata #1

tonilopezmr opened this issue Apr 8, 2016 · 7 comments
Assignees

Comments

@tonilopezmr
Copy link
Member

Create a package katapotter and do it.

@tonilopezmr
Copy link
Member Author

@JoseLlorensRipolles when is your solution?

@JoseLlorensRipolles
Copy link
Member

Wow I've forgot! As soon as I can! Have you worked it out yet ? @tonilopezmr

@JoseLlorensRipolles
Copy link
Member

Hey @tonilopezmr I've just finished it. You can take a look at my fork (https://github.com/JoseLlorensRipolles/Katas/blob/master-java/KataPotter/src/main/java/katapotter/KataPotter.java).

What do you think about it ? I'll continue refractoring it when I have some time!

@tonilopezmr
Copy link
Member Author

tonilopezmr commented Jul 1, 2016

Your code it's very ugly, it's not object oriented but if you are happy with your code.

I'm going to implement the sets and we can compare, anyway with your test you can refactor easily 👍

But what happens with your code non object oriented? If you have a bit change with your data you need also change the test, in object oriented that does not occurs, because your bussines logic is encapsulated in objects.

@JoseLlorensRipolles
Copy link
Member

I'm not sure on how to use the OO paradigm here. We can discuss it in slack. Eitherway I'll improve my code as soos as I can @tonilopezmr

@tonilopezmr
Copy link
Member Author

It's not difficult, a book is a Book, a collection of books is a BookBasket with price, etc, etc...

Transform your thought to code.

@tonilopezmr
Copy link
Member Author

@JoseLlorensRipolles Hey have a PR!! to add the KataPotter !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants