Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving security in shared links #514

Open
PalashTanejaPro opened this issue Apr 7, 2019 · 1 comment
Open

Improving security in shared links #514

PalashTanejaPro opened this issue Apr 7, 2019 · 1 comment

Comments

@PalashTanejaPro
Copy link
Contributor

Currently, the link sharing system uses simple number based indexing to access models from the db. This has a minor security issue because all user created models can be trivially retrieved by just iterating from all numbers from 1 to the currrent counter by changing the id parameter in the URL.

http://fabrik.cloudcv.org/load?id=2

Ideally, you would want to create a random string that is at least 12 characters long in order to make this completely secure. Shouldn't be too hard to implement.

@LuckyPigeon
Copy link

@PalashTanejaPro May I implement this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants