Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabrik is built with DEBUG settings #512

Open
TimVanMourik opened this issue Feb 13, 2019 · 1 comment
Open

Fabrik is built with DEBUG settings #512

TimVanMourik opened this issue Feb 13, 2019 · 1 comment

Comments

@TimVanMourik
Copy link

To reproduce:

Behaviour

Because the GitHub login throws an error, a Django debug page is shown and your environment variables are there to see for public. Nothing sensitive (no SECRET_KEY and all), but still.

Expected behaviour

An error 500 screen should be shown.

Suggested solution

Currently the production settings are probably using the regular settings file with DEBUG=True hard-coded in them:
https://github.com/Cloud-CV/Fabrik/blob/master/settings/common.py line 14

Either make a separate production settings file or read the DEBUG setting from an environment variable:
DEBUG=os.getenv('DEBUG', default_value)

@ajitesh-30
Copy link

@TimVanMourik Can i work on this issue .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants