Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share button should be disabled when canvas is empty #463

Open
gautamjajoo opened this issue Nov 19, 2018 · 5 comments
Open

Share button should be disabled when canvas is empty #463

gautamjajoo opened this issue Nov 19, 2018 · 5 comments

Comments

@gautamjajoo
Copy link
Member

gautamjajoo commented Nov 19, 2018

Observed Behaviour

One can get a shareable link if the canvas is empty.

Expected Behaviour

The share button should be disbaled

Would you like to work on it?

Yes

@Ram81

capture

@Ram81
Copy link
Member

Ram81 commented Nov 19, 2018

@gautamjajoo sure go ahead.

@rshrc
Copy link

rshrc commented Dec 13, 2018

Is there a current pull request regarding this feature request?

@gautamjajoo
Copy link
Member Author

@rshrc No, I haven't opened a PR yet, will be doing in some time.

@rshrc
Copy link

rshrc commented Dec 13, 2018

@gautamjajoo I was learning React, and thought of this as an easy issue, can I work on it? Maybe you can walk me through on how to go about it? I'll get familiar with the code base on the way. If possible obviously.

@gautamjajoo
Copy link
Member Author

@rshrc Ok, you can work on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants