Fix #447: Changed format for exporting models to MetaGraphDef for Tensorflow #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haabhi nice work, can you test whether all models in FabrikZoo which were working before are still working after the change or not. |
|
@haabhi are you going to make the changes in import_graphdef as well ? |
|
@yashdusing Yes, I am doing that at the moment. I am working on importing both metagraphdefs and graphdefs so the model zoo models and models exported from fabrik both work. |
|
@Ram81 @yashdusing |
Ram81
requested changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Fabrik export models as MetaGraphDef instead of Graphdef, which fixes #447. Doing this allows models built in Fabrik to be imported into Tensorflow seamlessly.