Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Delete multiple layers in Fabrik #317

Open
thatbrguy opened this issue Feb 28, 2018 · 13 comments
Open

Feature Request: Delete multiple layers in Fabrik #317

thatbrguy opened this issue Feb 28, 2018 · 13 comments

Comments

@thatbrguy
Copy link
Contributor

As of now, we can delete one layer at a time. We have to select the layer we want to delete and scroll all the way to the bottom to delete the layer.

It's usually a hindrance if you want to make lots of changes to your network, but also do not want to clear everything.

A good solution would be to introduce an option to select and delete multiple layers. Please be sure to update parameter count and other relevant attributes accordingly.

@yashdusing
Copy link
Contributor

Can I work on this ? I'm not well versed with React yet so it might take some time

@thatbrguy
Copy link
Contributor Author

@yashdusing Verify in Gitter if someone else had already started work before you and if not, take it.

Regarding the issue though, I have a suggestion. You could introduce a button under actions called "Delete mode", and call the already existing delete function whenever delete mode is enabled and you click a layer.

You could also implement your own solution

@Ram81
Copy link
Member

Ram81 commented Mar 1, 2018

@yashdusing I agree with @thatbrguy , doing it with the mode functionality would be better from user's point of view. If you have any other approaches in mind please go ahead with them.

@Shivanshmundra
Copy link
Contributor

@Ram81 @thatbrguy Can you review this?
@thatbrguy Is this what you wanted or something else?

@yashdusing
Copy link
Contributor

I was working on this :/

@Shivanshmundra
Copy link
Contributor

@yashdusing Sorry Due to no activity I thought issue is open.
Never mind, I had just started So you can take up issue.

@yashdusing
Copy link
Contributor

yashdusing commented Mar 13, 2018

If you don't mind me working on this that is, could you take up another issue or have you implemented it fully?

@Shivanshmundra
Copy link
Contributor

I have just implemented the basic part, So you can look at it and work on this issue.
I will find another issue.

@utsavgarg
Copy link
Contributor

@Shivanshmundra @yashdusing A more intuitive and simpler approach would be to include functionality which allows the user to use the delete key to remove a layer, this would make the process much faster.

@akshitac8
Copy link

Is this issue up for working?

@PalashTanejaPro
Copy link
Contributor

@utsavgarg I think this was already implemented in #238

@Gurpreetsingh9465
Copy link

Working on this issue

@Ram81
Copy link
Member

Ram81 commented Nov 18, 2018

@Gurpreetsingh9465 sure go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants