-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Delete multiple layers in Fabrik #317
Comments
Can I work on this ? I'm not well versed with React yet so it might take some time |
@yashdusing Verify in Gitter if someone else had already started work before you and if not, take it. Regarding the issue though, I have a suggestion. You could introduce a button under actions called "Delete mode", and call the already existing delete function whenever delete mode is enabled and you click a layer. You could also implement your own solution |
@yashdusing I agree with @thatbrguy , doing it with the mode functionality would be better from user's point of view. If you have any other approaches in mind please go ahead with them. |
@Ram81 @thatbrguy Can you review this? |
I was working on this :/ |
@yashdusing Sorry Due to no activity I thought issue is open. |
If you don't mind me working on this that is, could you take up another issue or have you implemented it fully? |
I have just implemented the basic part, So you can look at it and work on this issue. |
@Shivanshmundra @yashdusing A more intuitive and simpler approach would be to include functionality which allows the user to use the |
Is this issue up for working? |
@utsavgarg I think this was already implemented in #238 |
Working on this issue |
@Gurpreetsingh9465 sure go ahead. |
As of now, we can delete one layer at a time. We have to select the layer we want to delete and scroll all the way to the bottom to delete the layer.
It's usually a hindrance if you want to make lots of changes to your network, but also do not want to clear everything.
A good solution would be to introduce an option to select and delete multiple layers. Please be sure to update parameter count and other relevant attributes accordingly.
The text was updated successfully, but these errors were encountered: