Skip to content

Fixes #4289: Updates new Twitter (X) logo #4290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Gautam413
Copy link

The PR fixes #4289 and updates the twitter logo to the new one.
image

image

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.30%. Comparing base (96968d6) to head (640cebe).
Report is 1120 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4290      +/-   ##
==========================================
- Coverage   72.93%   69.30%   -3.63%     
==========================================
  Files          83       20      -63     
  Lines        5368     3574    -1794     
==========================================
- Hits         3915     2477    -1438     
+ Misses       1453     1097     -356     

see 64 files with indirect coverage changes

see 64 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f705b19...640cebe. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Gautam413 Gautam413 changed the title Fixex #4289: Updates new Twitter (X) logo Fixes #4289: Updates new Twitter (X) logo Mar 11, 2024
@TanishkaDarira
Copy link

This problem can be resolved by utilizing the fontawesome Twitter X icon instead. This will ensure consistency with the existing structure, as other icons are sourced from fontawesome as well.

image

https://fontawesome.com/icons/x-twitter?f=brands&s=solid

@RishabhJain2018
Copy link
Member

Closing this since this is not the standard way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Twitter (X) Logo to New one.
4 participants